feat: enable any variables without maps #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd93
force-pushed
the
enable-any-variables-without-maps
branch
from
31366c1 to
681281f
Compare
pd93
force-pushed
the
enable-any-variables-without-maps
branch
2 times, most recently
from
0a37851 to
898e456
Compare
andreynering
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Looks good!
I liked the blog article. We can post it /r/golang and others once it is released.
pd93
force-pushed
the
enable-any-variables-without-maps
branch
from
898e456 to
a170074
Compare
pd93
added a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to merge support for the "Any Variables" experiment into main, but without support for maps. The experiment has been open for a while now and as far as I can tell, there have been no issues with the support for basic variable types (
bool,int,float,arrays). The only contentious issues have been around maps and the breaking changes involved.This PR removes the
TASK_X_ANY_VARIABLESexperimental flag so that all functionality from the experiment is generally available with the exception of map variables which are now locked behind the newTASK_X_MAP_VARIABLESflag.All of the docs have been updated to reflect these changes and I've also added a short (draft) blog post too!
Thing to do if proposal accepted: