fix: fix bug for files with special chars &()
#1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
force-pushed
the
bug/fix-special-file-char
branch
from
2f09a48 to
2ddf82d
Compare
vergenzt
reviewed
Apr 18, 2024
Comment on lines
+106
to
+108
| s = strings.ReplaceAll(s, "&", `\&`) | ||
| s = strings.ReplaceAll(s, "(", `\(`) | ||
| s = strings.ReplaceAll(s, ")", `\)`) |
There was a problem hiding this comment.
Should this not do something along the lines of "shell quote the string"? Instead of escaping individual characters one at a time?
There was a problem hiding this comment.
yeah - something like https://pkg.go.dev/github.com/frioux/shellquote@v0.0.2 seems more complete
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1551