Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task executable variable #1624

Merged
merged 1 commit into from
May 16, 2024
Merged

feat: task executable variable #1624

merged 1 commit into from
May 16, 2024

Conversation

pd93
Copy link
Member

@pd93 pd93 commented Apr 26, 2024

Fixes #1616

I've gone with TASK_EXE instead of TASK_EXECUTABLE as suggested simply because its a bit shorter. Thoughts welcome.

@pd93 pd93 requested a review from andreynering May 10, 2024 19:25
@andreynering andreynering force-pushed the 1616-task-executable-var branch from 9c4b095 to fefb0b8 Compare May 16, 2024 00:43
Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I did a quick test on Windows and noticed it requires filepath.ToSlash to work properly, so I updated the branch with this fix.

@andreynering andreynering added the area: variables Changes related to variables. label May 16, 2024
@andreynering andreynering merged commit 252d549 into main May 16, 2024
13 checks passed
@andreynering andreynering deleted the 1616-task-executable-var branch May 16, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: variables Changes related to variables.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TASK_EXECUTABLE_PATH variable
2 participants