feat: add tag and pr number to ui (#427)

* add tag and pr number to ui * remove unused import, fix comment
go-vela · Aug 6, 2021 · 7508591 · 7508591
1 parent 9ffe858
commit 7508591
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 7 deletions.
diff --git a/src/elm/Pages/Build/View.elm b/src/elm/Pages/Build/View.elm
@@ -79,7 +79,7 @@ import Routes exposing (Route(..))
 import String
 import SvgBuilder exposing (buildStatusToIcon, stepStatusToIcon)
 import Time exposing (Posix, Zone)
-import Util
+import Util exposing (getNameFromRef)
 import Vela
     exposing
         ( Build
@@ -187,12 +187,37 @@ viewPreview now zone org repo build =
             [ buildStatusToIcon build.status ]
 
         commit =
-            [ repoLink
-            , text <| String.replace "_" " " build.event
-            , text " ("
-            , a [ href build.source ] [ text <| Util.trimCommitHash build.commit ]
-            , text <| ")"
-            ]
+            case build.event of
+                "pull_request" ->
+                    [ repoLink
+                    , text <| String.replace "_" " " build.event
+                    , text " "
+                    , a [ href build.source ]
+                        [ text "#"
+                        , text (getNameFromRef build.ref)
+                        ]
+                    , text " ("
+                    , a [ href build.source ] [ text <| Util.trimCommitHash build.commit ]
+                    , text <| ")"
+                    ]
+
+                "tag" ->
+                    [ repoLink
+                    , text <| String.replace "_" " " build.event
+                    , text " "
+                    , a [ href build.source ] [ text (getNameFromRef build.ref) ]
+                    , text " ("
+                    , a [ href build.source ] [ text <| Util.trimCommitHash build.commit ]
+                    , text <| ")"
+                    ]
+
+                _ ->
+                    [ repoLink
+                    , text <| String.replace "_" " " build.event
+                    , text " ("
+                    , a [ href build.source ] [ text <| Util.trimCommitHash build.commit ]
+                    , text <| ")"
+                    ]
 
         branch =
             [ a [ href <| Util.buildBranchUrl build.clone build.branch ] [ text build.branch ] ]

diff --git a/src/elm/Util.elm b/src/elm/Util.elm
@@ -18,6 +18,7 @@ module Util exposing
     , fiveSecondsMillis
     , formatRunTime
     , formatTestTag
+    , getNameFromRef
     , humanReadableDateTimeFormatter
     , humanReadableWithDefault
     , isLoading
@@ -479,3 +480,22 @@ buildBranchUrl clone branch =
 trimCommitHash : String -> String
 trimCommitHash commit =
     String.left 7 commit
+
+
+{-| getNameFromRef : parses the name from git for easy consumption
+-}
+getNameFromRef : String -> String
+getNameFromRef s =
+    let
+        sp =
+            String.split "/" s
+
+        n =
+            List.head (List.drop 2 sp)
+    in
+    case n of
+        Just name ->
+            name
+
+        _ ->
+            ""