test(secrets): cypress tests for secrets #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plyr4
commented
May 12, 2020
| "There was an error fetching your available repositories... Click Refresh or try again later!" | ||
| ] | ||
| ] | ||
| viewResourceError { resourceLabel = "your available repositories", testLabel = "repos" } |
There was a problem hiding this comment.
added a helper class for the "try again later!" we test for
plyr4
commented
May 12, 2020
| in | ||
| ( { model | secretsModel = { secretsModel | secrets = mergedSecrets } }, Cmd.none ) | ||
|
|
||
| Err error -> |
There was a problem hiding this comment.
added account for GET failure
plyr4
commented
May 12, 2020
| @@ -89,3 +91,17 @@ wrapErrorContent content = | |||
|
|
|||
| else | |||
| " (" ++ content ++ ")" | |||
|
|
|||
|
|
|||
| {-| viewResourceError : renders generic error message when there is a problem fetching a resource from Vela. | |||
There was a problem hiding this comment.
helper function for rendering GET failures
plyr4
commented
May 12, 2020
| @@ -1067,6 +1069,45 @@ secretTypeToString type_ = | |||
| "repo" | |||
|
|
|||
|
|
|||
| {-| secretsErrorLabel : helper to convert SecretType to string for printing GET secrets resource errors | |||
There was a problem hiding this comment.
added some more info for GET failures on particular secrets data
wass3r
approved these changes
May 13, 2020
plyr4
added a commit
that referenced
this pull request
Aug 19, 2022
* wrapped secret in RemoteData, added resourceError helper class, added remotedata failure logic to secrets page * lint * adding test labels to Table.View * more generic cypress tests for rendering secrets * cypress tests. linting. * oof, forgot to update hooks * remove redundant case * updating grammar in add repos test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.