Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo_settings/build): approve build mechanism and related repo settings #745

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

ecrupper
Copy link
Contributor

Repo settings page (a little wordy... open to suggestions):

Screenshot 2023-12-10 at 10 40 35 PM

Approve Build Look:

Screenshot 2023-12-10 at 10 49 18 PM

I decided to remove the Restart button whenever a build is in a pending approval state as well.

@ecrupper ecrupper requested a review from a team as a code owner December 11, 2023 04:52
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the verbiage on the settings page doesn't mention "Fork" at all. I think we want to differentiate between regular PRs and Fork PRs here, no?

@ecrupper
Copy link
Contributor Author

the verbiage on the settings page doesn't mention "Fork" at all. I think we want to differentiate between regular PRs and Fork PRs here, no?

I was thinking that "outside contributors" was somewhat covering that, but I can mention forks specifically

@wass3rw3rk
Copy link
Member

wass3rw3rk commented Dec 11, 2023

yea.. wanted to close the gap from "outside contributors" -> "fork". it can get a little wishy washy with collaborator/contributor terminology, too. @wass3r is an "external collaborator" but can create non-forked branches, for example. i think "fork" is pretty common terminology that will add more clarity.

thanks for the edit.

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 25da227 into main Dec 12, 2023
12 checks passed
@ecrupper ecrupper deleted the feat/fork-pr-approve-build branch December 12, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants