-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repo_settings/build): approve build mechanism and related repo settings #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the verbiage on the settings page doesn't mention "Fork" at all. I think we want to differentiate between regular PRs and Fork PRs here, no?
I was thinking that "outside contributors" was somewhat covering that, but I can mention forks specifically |
yea.. wanted to close the gap from "outside contributors" -> "fork". it can get a little wishy washy with collaborator/contributor terminology, too. @wass3r is an "external collaborator" but can create non-forked branches, for example. i think "fork" is pretty common terminology that will add more clarity. thanks for the edit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Repo settings page (a little wordy... open to suggestions):
Approve Build Look:
I decided to remove the
Restart
button whenever a build is in apending approval
state as well.