Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form style consistency #762

Merged
merged 4 commits into from
Feb 2, 2024
Merged

fix: form style consistency #762

merged 4 commits into from
Feb 2, 2024

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Feb 1, 2024

No description provided.

there were some structural DOM differences between deployment and other forms.
fixed those along with ensuring form width doesn't expand beyond a certain point
to help with containing two column form control layout.
@wass3r wass3r requested a review from a team as a code owner February 1, 2024 15:38
@ecrupper
Copy link
Contributor

ecrupper commented Feb 1, 2024

Screenshot 2024-02-01 at 9 47 52 AM

I think delete needs the same class applied

@plyr4
Copy link
Contributor

plyr4 commented Feb 1, 2024

nice

@wass3r
Copy link
Collaborator Author

wass3r commented Feb 1, 2024

@ecrupper you passed the test 😬 thanks for catching that. should be good now.

@wass3rw3rk wass3rw3rk merged commit a8020aa into main Feb 2, 2024
13 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/form-styles branch February 2, 2024 15:14
plyr4 added a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants