Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add comments to refactored ui #775

Merged
merged 232 commits into from
May 10, 2024
Merged

docs: add comments to refactored ui #775

merged 232 commits into from
May 10, 2024

Conversation

KellyMerrick
Copy link
Contributor

No description provided.

KellyMerrick and others added 30 commits December 27, 2023 15:56
@KellyMerrick
refactor(elm): created Shared model
8d26ab6
@plyr4
chore: elm-format
9bb887d
@plyr4
chore: refactor toasties
ba318a8
@plyr4
chore: remove repo
d181af0
@KellyMerrick
refactor(elm): refactored user using shared model
6ef7c53
@KellyMerrick
refactor(elm): refactored sourceRepos using shared model
f4e6dce
@KellyMerrick
refactor(elm): refactored time using shared model
88f4189
@KellyMerrick
refactor(elm): refactored entryURL using shared model
a9d9549
@KellyMerrick
refactor(elm): refactored visibility using shared model
e483ba0
@KellyMerrick
refactor(elm): refactored buildMenuOpen using shared model
23cf225
@plyr4
refactor(elm): refactored pipeline using shared model
b74c369
@plyr4
refactor(elm): refactored templates using shared model
8128c6d
@plyr4
refactor(elm): exposing only model
2bf109e
@plyr4
refactor(elm): todo comments and use Shared.Flags
f57fece
@plyr4
refactor(elm): prepare for Msg and more todo comments
876fa65
@plyr4
refactor: starting to deal with Effect, Pages, and tons of Msg
d6f728b
@KellyMerrick
refactor(elm): starting to populate new home page
42007f3
@plyr4
refactor: split Api.elm to fix cycle import with refactored msg flow
230765d
@plyr4
refactor: rename page to legacyPage, rename pageModel to page, reorde…
95ba8bf 
…r Model to match elm-land
@plyr4
refactor: make init look like elm-land init
be1c083
@plyr4
refactor: organized Main.elm into sections of keep then remove
acc4ff0
@plyr4
refactor: tons of main.elm organization, layouts, auth, and login code
daecf39
@plyr4
refactor: auth working, tons of comments, needs cleanup
a8b3e12
@plyr4
refactor: cleaning up auth code and moving things to shared.msg
f7cc6de
@plyr4
refactor: moved clipboard copy alert to shared.msg
2c88b43
@plyr4
refactor: adding Authenticate page
6d2f97e
@plyr4
refactor: fixed auth/login flow, implemented most of source repos
47b7018
@plyr4
refactor: dynamic route, and functioning default layout, work in prog…
f2e3d40 
…ress
@plyr4
refactor: components for the default layout, layout and component props
3e0047a
@plyr4
refactor: rename Login_ model to AccountLogin_
f2a2b44
plyr4
plyr4 previously requested changes May 8, 2024
View reviewed changes
src/elm/Components/Build.elm Outdated Show resolved Hide resolved
src/elm/Components/Search.elm Outdated Show resolved Hide resolved
src/elm/Components/Secrets.elm Outdated Show resolved Hide resolved
src/elm/Layout.elm Outdated Show resolved Hide resolved
src/elm/Main/Layouts/Model.elm Outdated Show resolved Hide resolved
src/elm/Pages/Org_/Repo_/Build_/Pipeline.elm Outdated Show resolved Hide resolved
src/elm/Route/Path.elm Outdated Show resolved Hide resolved
src/elm/Route/Query.elm Outdated Show resolved Hide resolved
tests/NoneTest.elm Outdated Show resolved Hide resolved
src/elm/Components/Util.elm Outdated Show resolved Hide resolved
KellyMerrick and others added 10 commits May 8, 2024 13:17
@KellyMerrick @plyr4
Update src/elm/Components/Build.elm
527d285 
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
@KellyMerrick @plyr4
Update src/elm/Components/Search.elm
cf26480 
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
@KellyMerrick @plyr4
Update src/elm/Pages/Org_/Repo_/Build_/Pipeline.elm
ce1ca86 
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
@KellyMerrick @plyr4
Update src/elm/Components/Util.elm
6e1556e 
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
@KellyMerrick
docs(various): address feedback
7430612
@KellyMerrick
Merge branch 'refactor/elm-rebuild_comments' of github.com:go-vela/ui…
8f9f683 
… into refactor/elm-rebuild_comments
@KellyMerrick
docs(Route): removing comments
b09c9d2
@KellyMerrick @plyr4
Update src/elm/Pages/Org_/Builds.elm
aafbb9c 
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
@KellyMerrick @plyr4
Update src/elm/Pages/Org_.elm
4635074 
Co-authored-by: dave vader <48764154+plyr4@users.noreply.github.com>
@KellyMerrick
docs(Main/Pages): removing comments
6fc0b29
@KellyMerrick KellyMerrick requested a review from plyr4 May 8, 2024 18:42
@KellyMerrick KellyMerrick dismissed plyr4’s stale review May 8, 2024 18:46

feedback addressed

wass3r
wass3r previously approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing major, looks good to me. thanks for going through those.

src/elm/Components/Alerts.elm Show resolved Hide resolved
src/elm/Components/Crumbs.elm Show resolved Hide resolved
plyr4
plyr4 previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for doing this. huge improvement

@plyr4 plyr4 dismissed stale reviews from wass3r and themself via aaf55fa May 10, 2024 18:45
plyr4
plyr4 previously approved these changes May 10, 2024
View reviewed changes
@plyr4 plyr4 merged commit 51f10c4 into main May 10, 2024
13 checks passed
@plyr4 plyr4 deleted the refactor/elm-rebuild_comments branch May 10, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsan3 wsan3 wsan3 left review comments

@ecrupper ecrupper ecrupper approved these changes

@plyr4 plyr4 plyr4 approved these changes

@wass3r wass3r wass3r left review comments

Assignees

@KellyMerrick KellyMerrick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KellyMerrick @plyr4 @wsan3 @wass3r @ecrupper