Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore favicon on dashboards page #804

Merged
merged 1 commit into from
Jun 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/elm/Pages/Dashboards/Dashboard_.elm
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import Route.Path
import Shared
import Time
import Utils.Errors as Errors
import Utils.Favicons as Favicons
import Utils.Helpers as Util
import Utils.Interval as Interval
import Vela
Expand Down Expand Up @@ -111,12 +112,15 @@ type alias Model =
init : Shared.Model -> Route { dashboard : String } -> () -> ( Model, Effect Msg )
init shared route () =
( { dashboard = RemoteData.Loading }
, Effect.getDashboard
{ baseUrl = shared.velaAPIBaseURL
, session = shared.session
, onResponse = GetDashboardResponse
, dashboardId = route.params.dashboard
}
, Effect.batch
[ Effect.updateFavicon { favicon = Favicons.defaultFavicon }
, Effect.getDashboard
{ baseUrl = shared.velaAPIBaseURL
, session = shared.session
, onResponse = GetDashboardResponse
, dashboardId = route.params.dashboard
}
]
)


Expand Down
Loading