fix: allow starlark limit to be customized #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plyr4
changed the title
timhuynh94
previously approved these changes
Aug 21, 2024
ecrupper
previously approved these changes
Aug 21, 2024
wass3rw3rk
approved these changes
Aug 21, 2024
ecrupper
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i knew this would come back to bite. we tried updating it LIVE to 20k but had to use the API.
this PR bumps the default limit to
99999and also addsVELA_MAX_STARLARK_EXEC_LIMITas an available variable to allow this to be decreased or increased based on how admins have their server installed.