Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update module masterminds/semver to v3 #63

Merged
merged 5 commits into from
Jan 8, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 6, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
github.com/Masterminds/semver require major v1.5.0 -> v3.1.1

Release Notes

Masterminds/semver

v3.1.1

Compare Source

Fixed
  • #​158: Fixed issue with generated regex operation order that could cause problem

v3.1.0

Compare Source

Added
Changed
  • #​148: More accurate validation messages on constraints

v3.0.3

Compare Source

Fixed
  • #​141: Fixed issue with <= comparison

v3.0.2

Compare Source

Fixed

v3.0.1

Compare Source

#​125: Fixes issue with module path for v3

v3.0.0

Compare Source

This is a major release of the semver package which includes API changes. The Go
API is compatible with ^1. The Go API was not changed because many people are using
go get without Go modules for their applications and API breaking changes cause
errors which we have or would need to support.

The changes in this release are the handling based on the data passed into the
functions. These are described in the added and changed sections below.

Added
  • StrictNewVersion function. This is similar to NewVersion but will return an
    error if the version passed in is not a strict semantic version. For example,
    1.2.3 would pass but v1.2.3 or 1.2 would fail because they are not strictly
    speaking semantic versions. This function is faster, performs fewer operations,
    and uses fewer allocations than NewVersion.
  • Fuzzing has been performed on NewVersion, StrictNewVersion, and NewConstraint.
    The Makefile contains the operations used. For more information on you can start
    on Wikipedia at https://en.wikipedia.org/wiki/Fuzzing
  • Now using Go modules
Changed
  • NewVersion has proper prerelease and metadata validation with error messages
    to signal an issue with either of them
  • Handles space separated AND conditions in addition to ,
  • ^ now operates using a similar set of rules to npm/js and Rust/Cargo. If the
    version is >=1 the ^ ranges works the same as v1. For major versions of 0 the
    rules have changed. The minor version is treated as the stable version unless
    a patch is specified and then it is equivalent to =. One difference from npm/js
    is that prereleases there are only to a specific version (e.g. 1.2.3).
    Prereleases here look over multiple versions and follow semantic version
    ordering rules. This pattern now follows along with the expected and requested
    handling of this packaged by numerous users.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 6, 2021 18:40
@renovate
Copy link
Contributor Author

renovate bot commented Jan 6, 2021

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻️ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you check the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: docker run --rm --name=renovate_go --label=renovate_child -v "/mnt/renovate/gh/go-vela/vela-git":"/mnt/renovate/gh/go-vela/vela-git" -v "/tmp/renovate-cache":"/tmp/renovate-cache" -v "/tmp/renovate-cache/others/go":"/tmp/renovate-cache/others/go" -e GOPATH -e CGO_ENABLED -w "/mnt/renovate/gh/go-vela/vela-git" docker.io/renovate/go:1.13.15 bash -l -c "git config --global url.\"https://**redacted**@github.com/\".insteadOf \"https://github.com/\" && go get -d ./... && go mod tidy && go mod tidy"
go: github.com/Masterminds/semver/v3/v3@v3.1.1: reading github.com/Masterminds/semver/v3/v3/go.mod at revision v3/v3.1.1: unknown revision v3/v3.1.1

@renovate renovate bot force-pushed the renovate/git.luolix.top-masterminds-semver-3.x branch from 48e7a21 to 133335e Compare January 6, 2021 22:57
go.mod Outdated
@@ -3,7 +3,7 @@ module github.com/go-vela/vela-git
go 1.13

require (
github.com/Masterminds/semver v1.5.0
github.com/Masterminds/semver/v3/v3 v3.1.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it messed up here and doubled up on the /v3?

@renovate renovate bot force-pushed the renovate/git.luolix.top-masterminds-semver-3.x branch 2 times, most recently from ccac486 to d9b5eab Compare January 7, 2021 14:08
@renovate renovate bot force-pushed the renovate/git.luolix.top-masterminds-semver-3.x branch from d9b5eab to 68c5980 Compare January 8, 2021 21:35
@renovate renovate bot force-pushed the renovate/git.luolix.top-masterminds-semver-3.x branch from 68c5980 to 3271a47 Compare January 8, 2021 23:04
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #63 (30af25d) into master (e0dc188) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   45.90%   45.90%           
=======================================
  Files           6        6           
  Lines         281      281           
=======================================
  Hits          129      129           
  Misses        142      142           
  Partials       10       10           

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r wass3r merged commit d1f6b93 into master Jan 8, 2021
@wass3r wass3r deleted the renovate/git.luolix.top-masterminds-semver-3.x branch January 8, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants