Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for use-new-run #154

Merged
merged 3 commits into from
Jan 9, 2023
Merged

feat: add support for use-new-run #154

merged 3 commits into from
Jan 9, 2023

Conversation

jmccann
Copy link
Contributor

@jmccann jmccann commented Dec 28, 2022

@jmccann jmccann requested a review from a team as a code owner December 28, 2022 21:42
@codecov
Copy link

codecov bot commented Dec 28, 2022 •
edited
Loading

Codecov Report

Merging #154 (67d6478) into main (c249074) will decrease coverage by 0.20%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   42.41%   42.21%   -0.21%     
==========================================
  Files           7        7              
  Lines         587      597      +10     
==========================================
+ Hits          249      252       +3     
- Misses        336      343       +7     
  Partials        2        2
Impacted Files Coverage Δ
cmd/vela-kaniko/build.go 83.33% <ø> (ø)
cmd/vela-kaniko/main.go 0.00% <0.00%> (ø)
cmd/vela-kaniko/plugin.go 93.16% <100.00%> (+0.17%) ⬆️

plyr4
plyr4 previously approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for adding the flag

@jmccann jmccann requested a review from plyr4 December 29, 2022 16:50
wass3r
wass3r requested changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. one minor nit.

DOCS.md Outdated Show resolved Hide resolved
@jmccann @wass3r
Update DOCS.md
67d6478 
Co-authored-by: David May <1301201+wass3r@users.noreply.github.com>
@jmccann
Copy link
Contributor Author

jmccann commented Jan 4, 2023

Thanks for the review @wass3r

wass3r
wass3r approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 289f059 into go-vela:main Jan 9, 2023
@jmccann jmccann deleted the use-new-run branch January 9, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3r wass3r wass3r approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vela kaniko - support --use-new-run param
3 participants
@jmccann @wass3r @plyr4