Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change snapshotMode to snapshot-mode #162

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

earwik
Copy link
Contributor

@earwik earwik commented Apr 24, 2023

Kaniko deprecated the --snapshotMode flag in favor of --snapshot-mode. This change gets rid of the warning level=warning msg="Flag --snapshotMode is deprecated. Use: --snapshot-mode" in current release.

@earwik earwik requested a review from a team as a code owner April 24, 2023 18:10
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks @earwik

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #162 (b28a4e4) into main (0025f90) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   42.21%   42.21%           
=======================================
  Files           7        7           
  Lines         597      597           
=======================================
  Hits          252      252           
  Misses        343      343           
  Partials        2        2           
Impacted Files Coverage Δ
cmd/vela-kaniko/plugin.go 93.16% <100.00%> (ø)

@wass3rw3rk wass3rw3rk merged commit 7f8bb97 into go-vela:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants