Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(flags): add compressed caching, log timestamp, and ignore path flags #197

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

@ecrupper ecrupper requested a review from a team as a code owner August 20, 2024 14:40
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 13.51351% with 32 lines in your changes missing coverage. Please review.

Project coverage is 32.76%. Comparing base (6645c4a) to head (79d1366).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/vela-kaniko/main.go 0.00% 30 Missing ⚠️
cmd/vela-kaniko/plugin.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
- Coverage   33.57%   32.76%   -0.81%     
==========================================
  Files           8        8              
  Lines         557      586      +29     
==========================================
+ Hits          187      192       +5     
- Misses        370      393      +23     
- Partials        0        1       +1     
Files Coverage Δ
cmd/vela-kaniko/build.go 100.00% <ø> (ø)
cmd/vela-kaniko/repo.go 100.00% <ø> (ø)
cmd/vela-kaniko/plugin.go 92.94% <71.42%> (-1.94%) ⬇️
cmd/vela-kaniko/main.go 0.00% <0.00%> (ø)

plyr4
plyr4 previously approved these changes Aug 20, 2024
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

wass3rw3rk
wass3rw3rk previously approved these changes Aug 20, 2024
@ecrupper ecrupper dismissed stale reviews from wass3rw3rk and plyr4 via 79d1366 August 20, 2024 15:07
@ecrupper ecrupper merged commit cab1585 into main Aug 20, 2024
8 of 10 checks passed
@ecrupper ecrupper deleted the enhance/more-flags branch August 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants