Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kubectl and add gcloud auth plugin #150

Merged
merged 10 commits into from
Mar 30, 2023
Merged

update kubectl and add gcloud auth plugin #150

merged 10 commits into from
Mar 30, 2023

Conversation

darkstarmv
Copy link
Contributor

@darkstarmv darkstarmv commented Mar 22, 2023 •
edited
Loading

Changes:

  1. GKE requires new auth plugin, see https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke
  2. Update kubectl to the latest patch 1.24
  3. Updated example K8s Ingress resource to the latest syntax
  4. Updated documentation with GKE auth example

@darkstarmv
update kubectl and add gcloud auth plugin
453a203 
Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>
@darkstarmv darkstarmv requested a review from a team as a code owner March 22, 2023 20:54
@darkstarmv
update ingress config
8600519 
Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>
@darkstarmv
change to --dry-run=server
5d16a1f 
Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>
@darkstarmv
update doc with GKE auth example
44abaf1 
Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>
@darkstarmv
update endpoint name
6e326d4 
Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>
bzub
bzub previously approved these changes Mar 23, 2023
View reviewed changes
plyr4
plyr4 reviewed Mar 29, 2023
View reviewed changes
cmd/vela-kubernetes/apply.go Outdated Show resolved Hide resolved
@darkstarmv
remove empty line
3403e96 
Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>
@plyr4 plyr4 requested a review from cognifloyd March 29, 2023 15:35
cognifloyd
cognifloyd previously approved these changes Mar 30, 2023
View reviewed changes
plyr4
plyr4 previously approved these changes Mar 30, 2023
View reviewed changes
@darkstarmv darkstarmv dismissed stale reviews from plyr4 and cognifloyd via 1a414c3 March 30, 2023 16:06
@plyr4 plyr4 merged commit e22275c into go-vela:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plyr4 plyr4 plyr4 approved these changes

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

@cognifloyd cognifloyd cognifloyd left review comments

@bzub bzub bzub left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darkstarmv @cognifloyd @bzub @plyr4 @wass3rw3rk