Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: install curl inside base plugin image #176

Merged
merged 2 commits into from
Aug 14, 2024
Merged

enhance: install curl inside base plugin image #176

merged 2 commits into from
Aug 14, 2024

Conversation

AjaySridhara
Copy link
Contributor

This adds the curl and further details in
https://git.target.com/vela/feature-requests/issues/263

@AjaySridhara AjaySridhara requested a review from a team as a code owner July 31, 2024 18:33
wass3rw3rk
wass3rw3rk requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, but can we combine with previous RUN statement please?

@plyr4 plyr4 changed the title This PR adds cURL to the terraform plugin enhance: install curl inside base plugin image Aug 13, 2024
wass3rw3rk
wass3rw3rk reviewed Aug 13, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@AjaySridhara
Copy link
Contributor Author

@wass3rw3rk — Done, David. Appreciate the help in reviewing it.

@wass3rw3rk wass3rw3rk merged commit 152e707 into go-vela:main Aug 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhuynh94 timhuynh94 timhuynh94 approved these changes

@plyr4 plyr4 plyr4 approved these changes

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AjaySridhara @timhuynh94 @plyr4 @wass3rw3rk