Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md Section ####Other to windows #348

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

hi20160616
Copy link
Contributor

@hi20160616 hi20160616 commented Aug 17, 2021

Please provide Issues links to:

Add code:

sudo apt-get install gcc-multilib
sudo apt-get install gcc-mingw-w64
sudo apt-get install libz-mingw-w64-dev

Description

I'd try and pass test for cross-compile on ubuntu to windows i386 and x86_64, my case: https://github.com/hi20160616/robotclick/blob/main/.github/workflows/goreleaser.yml

I dig and read many issues here, and collect the right way to cross-compile for windows binary.
I think it will help someone like me to fix bugs while cross compile.
like error zlib.h cannot find out usually because of we installed it via source, that not useful on mingw-w64.
I also suggest this update to let newbee easy to use this grand code.

I'd try and pass test for cross-compile on ubuntu to windows i386 and x86_64, my case: https://github.com/hi20160616/robotclick/blob/main/.github/workflows/goreleaser.yml

I dig and read many issues here,  and collect the right way to cross-compile for windows binary.  
I think it will help someone like me to fix bugs while cross compile.  
like error `zlib.h cannot find out` usually because of we installed it via source, that not useful on **mingw-w64**.  
I also suggest this update to let newbee easy to use this grand code.
@hi20160616 hi20160616 requested a review from vcaesar as a code owner August 17, 2021 04:40
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vcaesar vcaesar added this to the v0.100.0 milestone Aug 17, 2021
@vcaesar
Copy link
Member

vcaesar commented Aug 17, 2021

This section should be in ## CrossCompiling #### Other to windows.

I'd try and pass test for cross-compile on ubuntu to windows i386 and x86_64, my case:   https://github.com/hi20160616/robotclick/blob/main/.github/workflows/goreleaser.yml. 

I dig and read many issues here,  and collect the right way to cross-compile for windows binary.  
I think it will help someone like me to fix bugs while cross compile.  
like error `zlib.h cannot find out` usually because of we installed it via source, that not useful on **mingw-w64**.  
I also suggest this update to let newbee easy to use this grand code.
@hi20160616 hi20160616 changed the title Update README.md section Ubuntu Update README.md Section ## CrossCompiling #### Other to windows. Aug 17, 2021
@hi20160616 hi20160616 changed the title Update README.md Section ## CrossCompiling #### Other to windows. Update README.md Section ## CrossCompiling -> Other to windows. Aug 17, 2021
@hi20160616 hi20160616 changed the title Update README.md Section ## CrossCompiling -> Other to windows. Update README.md Section CrossCompiling -> Other to windows. Aug 17, 2021
@hi20160616
Copy link
Contributor Author

This section should be in ## CrossCompiling #### Other to windows.

OK, done.

@hi20160616 hi20160616 changed the title Update README.md Section CrossCompiling -> Other to windows. Update README.md Section ####Other to windows. Aug 17, 2021
@hi20160616 hi20160616 changed the title Update README.md Section ####Other to windows. Update README.md Section ####Other to windows Aug 17, 2021
README.md Outdated Show resolved Hide resolved
@vcaesar vcaesar merged commit 7b5dd14 into go-vgo:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants