-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Succo's fix to cache decodeHooks #33
Conversation
This is awesome! 3x improvement on a real life code. |
@sagikazarmark Any chance you could help us get this reviewed and merged? It'd be really great to get this fix upstream so we can stop relying on a fork. Thanks! |
@cedric-cordenier of course! Would you mind rebasing/force pushing to trigger CI? Also, could you please link the original PR here for future reference? Thank you! |
Thanks @sagikazarmark, greatly appreciated! 🙏 The original PR is here: mitchellh#324 I've just merged main back into my branch. Let me know if you need me to do anything else :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) | `v2.0.0` -> `v2.1.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-viper%2fmapstructure%2fv2/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-viper%2fmapstructure%2fv2/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-viper%2fmapstructure%2fv2/v2.0.0/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-viper%2fmapstructure%2fv2/v2.0.0/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>go-viper/mapstructure (github.com/go-viper/mapstructure/v2)</summary> ### [`v2.1.0`](https://github.com/go-viper/mapstructure/releases/tag/v2.1.0) [Compare Source](https://github.com/go-viper/mapstructure/compare/v2.0.0...v2.1.0) #### What's Changed - build(deps): bump actions/setup-go from 5.0.0 to 5.0.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/28](https://github.com/go-viper/mapstructure/pull/28) - build(deps): bump actions/checkout from 4.1.1 to 4.1.6 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/27](https://github.com/go-viper/mapstructure/pull/27) - build(deps): bump golangci/golangci-lint-action from 3.7.0 to 6.0.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/26](https://github.com/go-viper/mapstructure/pull/26) - build(deps): bump actions/setup-go from 5.0.1 to 5.0.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/34](https://github.com/go-viper/mapstructure/pull/34) - build(deps): bump actions/checkout from 4.1.6 to 4.1.7 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/29](https://github.com/go-viper/mapstructure/pull/29) - Port Succo's fix to cache decodeHooks by [@​cedric-cordenier](https://github.com/cedric-cordenier) in [https://github.com/go-viper/mapstructure/pull/33](https://github.com/go-viper/mapstructure/pull/33) - build(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/38](https://github.com/go-viper/mapstructure/pull/38) - Add configuration option to specify tag value that indicates squash by [@​triarius](https://github.com/triarius) in [https://github.com/go-viper/mapstructure/pull/18](https://github.com/go-viper/mapstructure/pull/18) - Adding support for squash: interface. by [@​m1k1o](https://github.com/m1k1o) in [https://github.com/go-viper/mapstructure/pull/17](https://github.com/go-viper/mapstructure/pull/17) #### New Contributors - [@​dependabot](https://github.com/dependabot) made their first contribution in [https://github.com/go-viper/mapstructure/pull/28](https://github.com/go-viper/mapstructure/pull/28) - [@​cedric-cordenier](https://github.com/cedric-cordenier) made their first contribution in [https://github.com/go-viper/mapstructure/pull/33](https://github.com/go-viper/mapstructure/pull/33) - [@​triarius](https://github.com/triarius) made their first contribution in [https://github.com/go-viper/mapstructure/pull/18](https://github.com/go-viper/mapstructure/pull/18) - [@​m1k1o](https://github.com/m1k1o) made their first contribution in [https://github.com/go-viper/mapstructure/pull/17](https://github.com/go-viper/mapstructure/pull/17) **Full Changelog**: go-viper/mapstructure@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
#4464) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) | `v2.0.0` -> `v2.1.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-viper%2fmapstructure%2fv2/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-viper%2fmapstructure%2fv2/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-viper%2fmapstructure%2fv2/v2.0.0/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-viper%2fmapstructure%2fv2/v2.0.0/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-viper/mapstructure (github.com/go-viper/mapstructure/v2)</summary> ### [`v2.1.0`](https://github.com/go-viper/mapstructure/releases/tag/v2.1.0) [Compare Source](https://github.com/go-viper/mapstructure/compare/v2.0.0...v2.1.0) #### What's Changed - build(deps): bump actions/setup-go from 5.0.0 to 5.0.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/28](https://github.com/go-viper/mapstructure/pull/28) - build(deps): bump actions/checkout from 4.1.1 to 4.1.6 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/27](https://github.com/go-viper/mapstructure/pull/27) - build(deps): bump golangci/golangci-lint-action from 3.7.0 to 6.0.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/26](https://github.com/go-viper/mapstructure/pull/26) - build(deps): bump actions/setup-go from 5.0.1 to 5.0.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/34](https://github.com/go-viper/mapstructure/pull/34) - build(deps): bump actions/checkout from 4.1.6 to 4.1.7 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/29](https://github.com/go-viper/mapstructure/pull/29) - Port Succo's fix to cache decodeHooks by [@​cedric-cordenier](https://github.com/cedric-cordenier) in [https://github.com/go-viper/mapstructure/pull/33](https://github.com/go-viper/mapstructure/pull/33) - build(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/go-viper/mapstructure/pull/38](https://github.com/go-viper/mapstructure/pull/38) - Add configuration option to specify tag value that indicates squash by [@​triarius](https://github.com/triarius) in [https://github.com/go-viper/mapstructure/pull/18](https://github.com/go-viper/mapstructure/pull/18) - Adding support for squash: interface. by [@​m1k1o](https://github.com/m1k1o) in [https://github.com/go-viper/mapstructure/pull/17](https://github.com/go-viper/mapstructure/pull/17) #### New Contributors - [@​dependabot](https://github.com/dependabot) made their first contribution in [https://github.com/go-viper/mapstructure/pull/28](https://github.com/go-viper/mapstructure/pull/28) - [@​cedric-cordenier](https://github.com/cedric-cordenier) made their first contribution in [https://github.com/go-viper/mapstructure/pull/33](https://github.com/go-viper/mapstructure/pull/33) - [@​triarius](https://github.com/triarius) made their first contribution in [https://github.com/go-viper/mapstructure/pull/18](https://github.com/go-viper/mapstructure/pull/18) - [@​m1k1o](https://github.com/m1k1o) made their first contribution in [https://github.com/go-viper/mapstructure/pull/17](https://github.com/go-viper/mapstructure/pull/17) **Full Changelog**: go-viper/mapstructure@v2.0.0...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119-->
Like @Succo we are seeing a big performance hit from typedDecodeHook being called repeatedly.
Fixes #30