Skip to content

Commit

Permalink
docs(protocol): mark transports field as deprecated (#163)
Browse files Browse the repository at this point in the history
Mark CredentialCreationResponse.Transports as deprecated with doc-comments. This field was effectively deprecated in #113, but without any comments making that clear to consumers of the library.
  • Loading branch information
torkelrogstad authored Sep 15, 2023
1 parent 11d0961 commit dc095d0
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion protocol/credential.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ type ParsedPublicKeyCredential struct {
type CredentialCreationResponse struct {
PublicKeyCredential
AttestationResponse AuthenticatorAttestationResponse `json:"response"`
Transports []string `json:"transports,omitempty"`

// Deprecated: Transports is deprecated due to upstream changes to the API.
// Use the Transports field of AuthenticatorAttestationResponse
// instead. Transports is kept for backward compatibility, and should not
// be used by new clients.
Transports []string `json:"transports,omitempty"`
}

type ParsedCredentialCreationData struct {
Expand Down

0 comments on commit dc095d0

Please sign in to comment.