Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): clear staticcheck warnings on AttestationChallenge check #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(protocol): clear staticcheck warnings on AttestationChallenge check #255

wants to merge 1 commit into from

Commits on Jul 16, 2024

  1. refactor(protocol): clear staticcheck warnings on AttestationChalleng… 

    …e check

The first warning from `staticcheck` is about Yoda conditions (which hides another warning)

> protocol/attestation_androidkey.go:114:5: don't use Yoda conditions (ST1017)

The hidden warning on the same line with `bytes.Compare(...) != 0` is

> protocol/attestation_androidkey.go:114:5: should use !bytes.Equal(decoded.AttestationChallenge, clientDataHash) instead (S1004)
    @robert-wallis
    robert-wallis committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d40bb93 View commit details
    Browse the repository at this point in the history