Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop checking uniqueKeys once we've found 10 errors #544

Open
wants to merge 3 commits into
base: v3
Choose a base branch
from

Conversation

cjcullen
Copy link

@cjcullen cjcullen commented Nov 8, 2019

This includes the benchmark test cases from #543.

@cjcullen
Copy link
Author

cjcullen commented Nov 8, 2019

It's kinda overkill to "benchmark" this change, but:

$ benchcmp old.txt new.txt
benchmark                    old ns/op      new ns/op     delta
BenchmarkDuplicateKeys-6     2370532130     6586106       -99.72%

benchmark                    old allocs     new allocs     delta
BenchmarkDuplicateKeys-6     2002187        8139           -99.59%

benchmark                    old bytes     new bytes     delta
BenchmarkDuplicateKeys-6     171812904     1012729       -99.41%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant