Allow for Channels to be easily shared between PDs #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sympatron
force-pushed
the
channel-rework
branch
from
6def34d to
1218d34
Compare
|
@Sympatron rebase of this branch looks a bit tricky. Can take a look? |
Sympatron
force-pushed
the
channel-rework
branch
from
1218d34 to
2dcc94b
Compare
|
Sorry for the delay. Rebase is done now. |
sidcha
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #15. Currently dependent on #16 and #17.
With this change users of
libosdp-rsdon't need aChannelper PD anymore and can instead share a channel.