Enable GCC/clang -Wshadow compiler flag #136
Conversation
|
Ran CppBlockUtilsTests and DB1kIter. No new tests failed. (Three fail under OS X when running CppBlockUtilsTests.) It's a good idea to double check the code changes, though. I mostly added underscores but there were two variables that were duplicates of the variables they shadowed, with no apparent need for it. I deleted those shadow variables. |
|
I have a big commit coming with p2sh + p2wsh wallets with signing, as well as compressed keys. Could you rebase on that after I push that code? It's for tomorrow or the day after I believe. Code is mostly done, writing unit tests and debugging as we speak. |
|
Gaaaaah. Wish I had known this earlier. :/ I'll rebase once it's pushed. |
|
Yeah sorry about that, I tend to do few massive pushes lately. |
|
The big commit is pushed, go ahead |
droark
force-pushed
the
dev
branch
2 times, most recently
from
dc3e14a to
728a8d2
Compare
|
Rebased and slightly revised. The biggest change is that I went ahead and fixed the warnings in the the LMDB code. This should be fine. However, all these changes need to be carefully considered before accepting them. |
GCC/clang will now throw warnings whenever variables shadow other variables. Armory code was cleaned up to remove these warnings. (Third party code - LMDB and Crypto++ - and code generated by SWIG was not cleaned up.)
|
The changes to the custom lmdb cpp headers are fine, but I can't take any changes to mdb.c. It's basically pointless, as whenever I update LMDB, the entire changeset goes out the toilet. |
1a33fa2 Merge goatpig#138: Expose ripemd160 15ac927 Expose ripemd160 8863aa7 Merge goatpig#136: Extend btc_script_classify to correctly cover P2SH, P2PK 2540312 Extend btc_script_classify to correctly cover P2SH, P2PK 07a21a0 Merge goatpig#134: Add some script size sanity checks 269ab0e Add some script size sanity checks git-subtree-dir: cppForSwig/libbtc git-subtree-split: 1a33fa20cdd9d9ae19588ce23453bbbe864355b2
1a33fa20 Merge goatpig#138: Expose ripemd160 15ac927f Expose ripemd160 8863aa77 Merge goatpig#136: Extend btc_script_classify to correctly cover P2SH, P2PK 25403128 Extend btc_script_classify to correctly cover P2SH, P2PK 07a21a0a Merge goatpig#134: Add some script size sanity checks 269ab0e2 Add some script size sanity checks git-subtree-dir: cppForSwig/libbtc git-subtree-split: 1a33fa20cdd9d9ae19588ce23453bbbe864355b2
GCC/clang will now throw warnings whenever variables shadow other variables. Armory code was cleaned up to remove these warnings. (Third party code - LMDB and Crypto++ - and code generated by SWIG was not cleaned up.)