Source packaging fixes and RPM build support

.gitignore

@@ -140,4 +140,9 @@ _CppBlockUtils.*
 /cppForSwig/guardian/x64*
 /cppForSwig/x64*
 /cppForSwig/LMDB_Win/x64*
-/cppForSwig/x64/*.*
+/cppForSwig/x64/*.*
+
+dist
+BitcoinArmory-*.tar.gz
+BitcoinArmory.spec
+BitcoinArmory-*.rpm

ArmoryQt.py

@@ -1,4 +1,4 @@
-#! /usr/bin/python
+#!/usr/bin/python2
 # -*- coding: UTF-8 -*-
 ##############################################################################
 #                                                                            #

BitcoinArmory.spec.in

@@ -0,0 +1,45 @@
+# disable debug package, otherwise nasty build error in fedora >= 23
+%global debug_package %{nil}
+
+%define mybuildnumber %{?build_number}%{?!build_number:1}
+
+Name:     BitcoinArmory
+Version:  @PACKAGE_VERSION@
+Release:  %{mybuildnumber}%{?dist}
+Summary:  A high-security Bitcoin wallet
+Group:    Applications/Financial
+License:  MIT
+Source0:  bitcoinarmory-%{version}.tar.gz
+
+BuildRequires: python2-twisted, python2-psutil, swig, python2-devel, gcc-c++, PyQt4-devel, qt-devel, rsync
+Requires:      PyQt4, python-twisted, python-psutil
+%description
+This is a local full node implementation of an advanced Bitcoin wallet.
+
+%prep
+%setup -q -n bitcoinarmory-%{version}
+
+
+%build
+export PATH=/usr/lib64/qt4/bin:/usr/lib/qt4/bin:"$PATH"
+export PYTHON=%{_bindir}/python2
+%configure
+%make_build
+
+
+%install
+mkdir -p "%{buildroot}"/usr/share/applications
+export PATH=/usr/lib64/qt4/bin:/usr/lib/qt4/bin:"$PATH"
+export PYTHON=%{_bindir}/python2
+%make_install
+
+
+%files
+%defattr(-, root, root)
+%{_datadir}/applications/*.desktop
+%{_includedir}/*.h
+%{_libdir}/libfcgi.*
+%{_libdir}/libCppBlockUtils.*
+%{_prefix}/lib/armory
+%{_datadir}/armory/*
+%attr(0755, root, root) %{_bindir}/*

Jenkinsfile

@@ -0,0 +1,11 @@
+// https://github.com/Rudd-O/shared-jenkins-libraries
+@Library('shared-jenkins-libraries@master') _
+
+
+genericFedoraRPMPipeline(
+	null,
+	{
+		sh 'cd src && ./autogen.sh && PYTHON=/usr/bin/python2 ./configure --prefix=/usr && make srpm'
+	},
+	['autoconf', 'automake', 'libtool', 'gcc-c++', 'swig', 'python2-psutil', 'PyQt4-devel'],
+)

Makefile.am

@@ -5,13 +5,13 @@ EXTRA_DIST = *.py *.md LICENSE LICENSE-ATI LICENSE-MIT \
 	nginx_example.conf imgList.xml autogen.sh \
 	armoryengine/*.py ui/*.py \
 	img/* lang/* dpkgfiles/* \
-	windowsbuild/* linuxbuild/* osxbuild/*
+	windowsbuild/* linuxbuild/* osxbuild/* BitcoinArmory.spec
 
 ACLOCAL_AMFLAGS = -I m4
 
 lrelease:
 if HAVE_GUI
-	lrelease lang/*.ts
+	$(HAVE_LRELEASE) lang/*.ts
 endif
 
 qrc_img_resources.py: imgList.xml
@@ -66,10 +66,16 @@ endif
 
 # Skip Linux-specific steps on OSX.
 if ! BUILD_DARWIN
+# Unfuck broken build system that, upon make install, incorrectly
+# regenerates files with DESTDIR instead of prefix.
+# Who the hell uses autotools in 2017?
 if HAVE_GUI
 	rsync -rupE --exclude="img/.DS_Store" img $(DESTDIR)$(prefix)/share/armory/
 	sed "s: /usr: $(prefix):g" < dpkgfiles/armory > $(DESTDIR)$(prefix)/bin/armory
 	chmod +x $(DESTDIR)$(prefix)/bin/armory
+	mkdir -p $(DESTDIR)$(datadir)/applications
+	chmod 0755 $(DESTDIR)$(datadir)/applications
+	for f in armory.desktop armoryoffline.desktop armorytestnet.desktop ; do sed "s:/usr/local/bin:$(bindir):g" < dpkgfiles/$$f > $(DESTDIR)$(datadir)/applications/$$f ; chmod 0644 $(DESTDIR)$(datadir)/applications/$$f ; done
 endif
 endif
 
@@ -84,3 +90,11 @@ clean-local:
 	rm -f CppBlockUtils.py
 	rm -f _CppBlockUtils.so
 	rm -f CppBlockUtils.pyc
+
+srpm: dist
+	mkdir -p dist
+	tmpdir=`mktemp -d` ; rpmbuild --define "_topdir $$tmpdir" -ts bitcoinarmory-$(PACKAGE_VERSION).tar.gz && { mv -f "$$tmpdir"/SRPMS/* . ; } ; rm -rf "$$tmpdir"
+
+rpm: dist
+	mkdir -p dist
+	tmpdir=`mktemp -d` ; rpmbuild --define "_topdir $$tmpdir" -ta bitcoinarmory-$(PACKAGE_VERSION).tar.gz && { mv -f "$$tmpdir"/SRPMS/* "$$tmpdir"/RPMS/*/* . ; } ; rm -rf "$$tmpdir"

configure.ac

@@ -83,9 +83,10 @@ AC_CHECK_PROG([HAVE_PYRCC4], [pyrcc4], [yes], [no])
 AS_IF([test $HAVE_PYRCC4 == yes], [],
 	[AC_MSG_ERROR([missing pyrcc4 in path, make sure pyqt4-dev-tools is installed])]) 
 
-AC_CHECK_PROG([HAVE_LRELEASE], [lrelease], [yes], [no])
-AS_IF([test $HAVE_LRELEASE == yes], [],
-	[AC_MSG_ERROR([missing lrelease in path, make sure qt4-linguist-tools is installed])]) 
+AC_CHECK_PROGS([HAVE_LRELEASE], [lrelease lrelease-qt4], [no])
+AS_IF([test $HAVE_LRELEASE == no],
+	[AC_MSG_ERROR([missing lrelease in path, make sure qt4-linguist-tools is installed])], 
+        [])
 
 fi
 
@@ -164,7 +165,8 @@ AM_CONDITIONAL([BUILD_DARWIN], [test x$BUILD_OS = xdarwin])
 
 AC_CONFIG_FILES(Makefile
 		cppForSwig/Makefile
-		cppForSwig/lmdb/Makefile)
+		cppForSwig/lmdb/Makefile
+		BitcoinArmory.spec)
 
 AM_CONDITIONAL([BUILD_TESTS], [test "x$want_tests" = "xyes"])
 if test "x$want_tests" = "xyes"; then

cppForSwig/Makefile.am

@@ -20,6 +20,8 @@ if HAVE_CLANG
 SWIG_FLAGS += -D__CLANG__
 endif
 
+EXTRA_DIST = CppBlockUtils.i CppBlockUtils.py
+
 INCLUDE_FILES = UniversalTimer.h BinaryData.h lmdb_wrapper.h \
 	BtcUtils.h DBUtils.h BlockObj.h BlockUtils.h EncryptionUtils.h \
 	BtcWallet.h LedgerEntry.h ScrAddrObj.h Blockchain.h \
@@ -31,7 +33,12 @@ INCLUDE_FILES = UniversalTimer.h BinaryData.h lmdb_wrapper.h \
 	FcgiMessage.h BlockDataManagerConfig.h \
 	Transactions.h Script.h Signer.h nodeRPC.h JSON_codec.h \
 	ReentrantLock.h StringSockets.h log.h OS_TranslatePath.h \
-	TransactionBatch.h BlockchainScanner_Super.h SigHashEnum.h TxEvalState.h
+	TransactionBatch.h BlockchainScanner_Super.h SigHashEnum.h TxEvalState.h \
+	make_unique.h TxOutScrRef.h bdmenums.h DbHeader.h SocketIncludes.h \
+	PartialMerkle.h util.h WalletManager.h SwigClient.h Wallets.h \
+	CoinSelection.h LedgerEntryData.h ThreadSafeClasses.h \
+	Win_TranslatePath.h ScriptRecipient.h \
+	bech32/ref/c++/bech32.h bech32/ref/c++/segwit_addr.h
 
 DB_SOURCE_FILES = UniversalTimer.cpp BinaryData.cpp lmdb_wrapper.cpp \
 	BtcUtils.cpp DBUtils.cpp BlockObj.cpp BlockUtils.cpp EncryptionUtils.cpp \