-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark for stumpless_open_buffer_target #466
Add benchmark for stumpless_open_buffer_target #466
Conversation
60aceda
to
9dd6188
Compare
Issue #449 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #466 +/- ##
==========================================
+ Coverage 90.59% 90.60% +0.01%
==========================================
Files 47 47
Lines 4379 4385 +6
Branches 587 587
==========================================
+ Hits 3967 3973 +6
Misses 279 279
Partials 133 133 ☔ View full report in Codecov by Sentry. |
9dd6188
to
9c291c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great! Just one change requested to bring the resource usage down a bit.
da75262
to
3cc868e
Compare
3cc868e
to
5ef831e
Compare
Thanks very much for putting this change together and sticking with it through the review process! |
This pull request is related to solving the issue for adding a new benchmark for stumpless_open_buffer_target. A new benchmark file was also added as described on the issue 449.
This is a Work in Progress: I hope to improve this progressively through feedback from the community.