Remove deprecation warnings

goatslacker · Apr 25, 2015 · a76e048 · a76e048
1 parent 118b2fa
commit a76e048
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 46 deletions.
diff --git a/src/alt/AltStore.js b/src/alt/AltStore.js
@@ -1,7 +1,6 @@
 import EventEmitter from 'eventemitter3'
 import assign from 'object-assign'
 import Symbol from 'es-symbol'
-import { deprecatedBeforeAfterEachWarning } from './utils/warnings'
 import * as Sym from './symbols/symbols'
 
 const {
@@ -37,13 +36,6 @@ export default class AltStore {
     this.dispatchToken = alt.dispatcher.register((payload) => {
       if (model[LIFECYCLE].beforeEach) {
         model[LIFECYCLE].beforeEach(payload, this[STATE_CONTAINER])
-      } else if (typeof model.beforeEach === 'function') {
-        deprecatedBeforeAfterEachWarning()
-        model.beforeEach(
-          payload.action.toString(),
-          payload.data,
-          this[STATE_CONTAINER]
-        )
       }
 
       if (model[LISTENERS][payload.action]) {
@@ -66,13 +58,6 @@ export default class AltStore {
 
       if (model[LIFECYCLE].afterEach) {
         model[LIFECYCLE].afterEach(payload, this[STATE_CONTAINER])
-      } else if (typeof model.afterEach === 'function') {
-        deprecatedBeforeAfterEachWarning()
-        model.afterEach(
-          payload.action.toString(),
-          payload.data,
-          this[STATE_CONTAINER]
-        )
       }
     })
 

diff --git a/src/alt/utils/warnings.js b/src/alt/utils/warnings.js
@@ -4,10 +4,3 @@ export function warn(msg) {
     console.warn(new ReferenceError(msg))
   }
 }
-
-export function deprecatedBeforeAfterEachWarning() {
-  warn(
-    'beforeEach/afterEach functions on the store are deprecated ' +
-    'use beforeEach/afterEach as a lifecycle method instead'
-  )
-}
diff --git a/test/before-and-after-test.js b/test/before-and-after-test.js
@@ -1,5 +1,6 @@
-import Alt from '../dist/alt-with-runtime'
+import Alt from '../'
 import { assert } from 'chai'
+
 import sinon from 'sinon'
 
 const alt = new Alt()
@@ -85,28 +86,5 @@ export default {
       assert.ok(beforeValue === 1, 'before has current state')
       assert.ok(afterValue === 2, 'after has next state')
     },
-
-    'deprecated warning'() {
-      console.warn = sinon.spy()
-
-      class Foo {
-        constructor() {
-          this.bindListeners({
-            change: action.fire
-          })
-        }
-        beforeEach() { }
-        afterEach() { }
-        change() { }
-      }
-
-      assert(console.warn.callCount === 0)
-
-      alt.createStore(Foo)
-
-      action.fire()
-
-      assert.ok(console.warn.calledTwice)
-    }
   }
 }