Updated .waitFor() to allow passing store instances instead of tokens. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Will also accept multiple params instead of an array of items. Backwards compatible with Facebook's version of waitFor().
| sources = Array.prototype.slice.call( arguments) | ||
| } | ||
|
|
||
| let tokens = sources.map(( source)=>{ |
There was a problem hiding this comment.
Just a few whitespace nits:
removing leading whitespace from open paren, and add some whitespace between arrow and paren/brace:
let tokens = sources.map((source) => {
same for the slice call above.
|
lgtm! |
|
I think this addresses the whitespace niggles. You might consider putting a style guide of some sort in the repo (although it's possible I just missed it). 😁 |
|
#25 working on it! :) |
| waitFor(tokens) { | ||
| if (!tokens) { | ||
| waitFor(sources) { | ||
| if (! sources) { |
|
OK. Maybe that's the last one. :) |
|
I'll update the docs. Thanks 😄 |
goatslacker
added a commit
that referenced
this pull request
Mar 6, 2015
Updated .waitFor() to allow passing store instances instead of tokens.
|
Docs ced88f8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also accept multiple params instead of only an array of items. Backwards compatible with Facebook's version of waitFor().
As discussed in #38