Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: check remote IP for proxy protocol same as HTTP/etc #12094

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 20, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners November 20, 2024 17:35
@BeryJu
Copy link
Member Author

BeryJu commented Nov 20, 2024

/cherry-pick version-2024.10

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 9ccd728
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/673e1de0c4417c0007666fb9

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 9ccd728
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/673e1de0556344000810634a

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (dc9de43) to head (9ccd728).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12094   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files         761      761           
  Lines       37929    37929           
=======================================
+ Hits        35124    35125    +1     
+ Misses       2805     2804    -1     
Flag Coverage Δ
e2e 49.09% <ø> (+<0.01%) ⬆️
integration 24.85% <ø> (ø)
unit 90.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-9ccd7282003b97a03870dd66c817ce7c05bcc15a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-9ccd7282003b97a03870dd66c817ce7c05bcc15a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-9ccd7282003b97a03870dd66c817ce7c05bcc15a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-9ccd7282003b97a03870dd66c817ce7c05bcc15a-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit d4bf3b7 into main Nov 20, 2024
66 checks passed
@BeryJu BeryJu deleted the root/check-proxy-protocol-remote-ip branch November 20, 2024 20:33
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 20, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Nov 20, 2024
…#12094) (#12097)

root: check remote IP for proxy protocol same as HTTP/etc (#12094)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants