-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
root: Improve debugging experience #12961
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12961 +/- ##
==========================================
- Coverage 92.75% 92.69% -0.07%
==========================================
Files 785 785
Lines 39580 39623 +43
==========================================
+ Hits 36714 36728 +14
- Misses 2866 2895 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@BeryJu: For testing purpose I added some minor python changes. After that the breaking points around the changes didn't get hit anymore (which makes sense since the changes aren't visible in the container itself). volumes:
- ./authentik:/authentik to Maybe you could reevaluate your problem with this PR/comment |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
* main: (24 commits) core: add additional RBAC permission to restrict setting the superuser status on groups (#12900) web: bump API Client version (#13089) core: bump github.com/spf13/cobra from 1.8.1 to 1.9.1 (#13085) stages/authenticator_email: Email OTP (#12630) website: bump dompurify and mermaid in /website (#13077) web: bump dompurify and mermaid in /web (#13078) core: bump django-filter from 24.3 to 25.1 (#13086) enterprise/audit: fix diff being created when not enabled (#13084) core, web: update translations (#13088) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#13080) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#13081) translate: Updates for file web/xliff/en.xlf in zh-Hans (#13082) translate: Updates for file web/xliff/en.xlf in zh_CN (#13083) core: bump django-storages from 1.14.4 to 1.14.5 (#13087) web/user: fix redirects back to user settings (#13076) ci: parallelize unit tests (#13036) core, web: update translations (#13072) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#13073) root: Improve debugging experience (#12961) core, web: update translations (#13071) ...
Details
This PR is ment to improve the debugging experiance:
docker-compose.override.yml
is necessary due to website/docs: updated debugging docs #12809 it addsdocker-compose.override.yml
to gitignore to remove noice when comittingFurther thoughts:
Debug: Attach Worker
configuration since it only duplicatesDebug: Attach Server Core
in its curretns state. RenamingDebug: Attach Server Core
would be useful for clarification thenworker
andserver
should be able at the same time it would be necessary distinguish between both when setting up the debugging ports on startup or via port forwarding indocker-compose.override.yml
.Both needs to be documented somewhere
Dockerfile
(Sidemark: Image size will increase ~30%)Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)