-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
root: replace builtin psycopg libpq binary implementation with distro… #6448
Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
For reference and comparison: |
Setting up the dev env in the CI takes about the same time (2-3 minutes) |
… provided one Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6448 +/- ##
===========================================
+ Coverage 47.84% 92.45% +44.61%
===========================================
Files 561 561
Lines 27075 27075
===========================================
+ Hits 12951 25029 +12078
+ Misses 14124 2046 -12078
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Required for bootstrap & healtcheck | ||
apt-get install -y --no-install-recommends runit && \ | ||
pip install --no-cache-dir -r /requirements.txt && \ | ||
apt-get remove --purge -y build-essential pkg-config libxmlsec1-dev && \ | ||
apt-get remove --purge -y build-essential pkg-config libxmlsec1-dev libpq-dev python3-dev && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't python3-dev
interfere with the docker python install? Since I assume that one is not installed via dpkg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking what python3-dev
and dependencies install vs what's already bundled in the image, I don't think it will.
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-psycopg-c-1690924082-70dfd86
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s For arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-psycopg-c-1690924082-70dfd86-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s Afterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-psycopg-c-1690924082-70dfd86 For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-psycopg-c-1690924082-70dfd86-arm64 Afterwards, run the upgrade commands from the latest release notes. |
Docker image size is 1MB heavier with this PR. |
I was just about to comment on that, they look the same size here
|
I just realized but this may break some development environments if those packages are not installed. I'll put in a follow up PR to update the dev docs |
I did wonder about that too, but it installed just fine for me locally without any changes We do already tell people to install |
Yep, it will be fine indeed |
* main: (36 commits) website/blog: add github user name links (#6468) website/developer-docs: add new template for procedures (#6390) website/blogs: blog to celebrate hackathon (#6457) web/flows: add more stories (#6444) web: bump prettier from 3.0.0 to 3.0.1 in /web (#6465) core: bump debugpy from 1.6.7 to 1.6.8 (#6458) ci: bump peter-evans/create-pull-request from 4 to 5 (#6459) web: bump lit from 2.7.6 to 2.8.0 in /web (#6460) web: bump @fortawesome/fontawesome-free from 6.4.0 to 6.4.2 in /web (#6461) web: bump chart.js from 4.3.2 to 4.3.3 in /web (#6462) web: bump @lit-labs/task from 2.1.2 to 3.0.0 in /web (#6463) web, website: compress images (#6121) core: bump cryptography from 41.0.2 to 41.0.3 (#6456) root: replace builtin psycopg libpq binary implementation with distro… (#6448) website: fix broken links in NewsBar core: bump github.com/getsentry/sentry-go from 0.22.0 to 0.23.0 (#6449) core: bump goauthentik.io/api/v3 from 3.2023061.6 to 3.2023061.7 (#6450) web: bump pyright from 1.1.319 to 1.1.320 in /web (#6451) core: bump ruff from 0.0.281 to 0.0.282 (#6453) core: bump golang from 1.20.6-bullseye to 1.20.7-bullseye (#6454) ...
… provided one
Details
As discussed previously.
https://www.psycopg.org/psycopg3/docs/basic/install.html#local-installation recommends using the C implementation when possible.
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)make i18n-extract
)If applicable
make website
)