-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: optimise pagination in API schema #6478
Conversation
❌ Deploy Preview for authentik-storybook failed.
|
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
9b38610
to
31a0cdd
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
==========================================
- Coverage 92.47% 92.46% -0.01%
==========================================
Files 561 561
Lines 27075 27080 +5
==========================================
Hits 25036 25036
- Misses 2039 2044 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-api-optimise-pagination-1691241673-31a0cdd
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s For arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-api-optimise-pagination-1691241673-31a0cdd-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s Afterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-api-optimise-pagination-1691241673-31a0cdd For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-api-optimise-pagination-1691241673-31a0cdd-arm64 Afterwards, run the upgrade commands from the latest release notes. |
"end_index", | ||
], | ||
}, | ||
"pagination": {"$ref": f"#/components/schemas/{PAGINATION_COMPONENT_NAME}"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this wouldn't be hardcoded and we directly get the reference from the created component, but that's a bit of a challenge with the imports
* main: web/flows: fix identification stage band color (#6489) providers/proxy: only intercept auth header when a value is set (#6488) web: bump @goauthentik/api from 2023.6.1-1691242648 to 2023.6.1-1691266058 in /web (#6486) providers/proxy: set outpost session cookie to httponly and secure wh… (#6482) web: bump @esbuild/linux-arm64 from 0.18.17 to 0.18.18 in /web (#6483) web/admin: fix user sorting by active field (#6485) web: bump @esbuild/darwin-arm64 from 0.18.17 to 0.18.18 in /web (#6484) web: bump storybook (#6481) web: bump the sentry group in /web with 2 updates (#6480) web: bump API Client version (#6479) api: optimise pagination in API schema (#6478) website/dev-docs: tweaks to template (#6474) website: bump react-tooltip from 5.19.0 to 5.20.0 in /website (#6471) website: bump prettier from 3.0.0 to 3.0.1 in /website (#6472)
Details
Instead of having the schema of the pagination in each response component, have the pagination object once and reference it
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)make i18n-extract
)If applicable
make website
)