Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix potential infinite wait in tests spinning up a container #7153

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 12, 2023

Details

Integration tests have been randomly timing out after 30 mins, most likely due us infinitely waiting for containers to be healthy


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner October 12, 2023 11:18
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 19d9569
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6527d6dc24f0840008bddacd

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the tests/fix-infinite-wait branch from a69ebfc to 19d9569 Compare October 12, 2023 11:22
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ccd805e) 92.66% compared to head (19d9569) 92.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7153      +/-   ##
==========================================
+ Coverage   92.66%   92.67%   +0.01%     
==========================================
  Files         568      568              
  Lines       28049    28049              
==========================================
+ Hits        25990    25991       +1     
+ Misses       2059     2058       -1     
Flag Coverage Δ
e2e 51.18% <ø> (+0.01%) ⬆️
integration 26.34% <ø> (ø)
unit 89.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentik/root/test_runner.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-tests-fix-infinite-wait-1697110560-19d9569
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-tests-fix-infinite-wait-1697110560-19d9569-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-tests-fix-infinite-wait-1697110560-19d9569

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-tests-fix-infinite-wait-1697110560-19d9569-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit abab635 into main Oct 12, 2023
@BeryJu BeryJu deleted the tests/fix-infinite-wait branch October 12, 2023 11:57
kensternberg-authentik added a commit that referenced this pull request Oct 12, 2023
* main:
  web: patternfly hints as ak-web-component (#7120)
  web: fix form default submit handler (#7122)
  web/admin: add additional Flow info (#7155)
  tests: fix potential infinite wait in tests spinning up a container (#7153)
  ci: disable ghcr retention schedule while it's broken (#7154)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in de (#7151)
  core: bump golang.org/x/net from 0.16.0 to 0.17.0 (#7148)
  web: bump the babel group in /web with 5 updates (#7149)
  core: bump sentry-sdk from 1.31.0 to 1.32.0 (#7150)
  website: make get started on pricing page go to customer portal (#7147)
kensternberg-authentik added a commit that referenced this pull request Oct 12, 2023
* main:
  web: patternfly hints as ak-web-component (#7120)
  web: fix form default submit handler (#7122)
  web/admin: add additional Flow info (#7155)
  tests: fix potential infinite wait in tests spinning up a container (#7153)
  ci: disable ghcr retention schedule while it's broken (#7154)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in de (#7151)
  core: bump golang.org/x/net from 0.16.0 to 0.17.0 (#7148)
  web: bump the babel group in /web with 5 updates (#7149)
  core: bump sentry-sdk from 1.31.0 to 1.32.0 (#7150)
  website: make get started on pricing page go to customer portal (#7147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant