Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: translation-advice: avoid commenting after make i18n-extract [AUTH-145] #7563

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

rissson
Copy link
Member

@rissson rissson commented Nov 14, 2023

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Nov 14, 2023
@rissson rissson requested a review from a team as a code owner November 14, 2023 15:52
Copy link

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 9cfa778
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6553aa8dc479710008c31968

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (deb0cb2) 92.61% compared to head (9cfa778) 92.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7563   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files         587      587           
  Lines       29029    29029           
=======================================
  Hits        26885    26885           
  Misses       2144     2144           
Flag Coverage Δ
e2e 50.81% <ø> (ø)
integration 25.98% <ø> (ø)
unit 89.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson force-pushed the fix-translation-advice branch 2 times, most recently from fee7e85 to c5a923d Compare November 14, 2023 17:10
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson force-pushed the fix-translation-advice branch from c5a923d to 9cfa778 Compare November 14, 2023 17:12
@rissson
Copy link
Member Author

rissson commented Nov 14, 2023

Ok this only works for backend files, as all frontend files are updated when source strings are modified

@rissson rissson changed the title ci: translation-advice: avoid commenting after make i18n-extract AUTH-145 ci: translation-advice: avoid commenting after make i18n-extract [AUTH-145] Nov 14, 2023
@rissson rissson merged commit a2e5de1 into main Nov 15, 2023
@rissson rissson deleted the fix-translation-advice branch November 15, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants