Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outposts: disable deployment and secret reconciler for embedded outpost in code instead of in config #8021

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Dec 30, 2023

Details

Instead of relying on disabling the reconcilers in the outpost config, use the standard noop property


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner December 30, 2023 14:40
Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit a396089
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/659055dc04216f00081b5ed4

@BeryJu
Copy link
Member Author

BeryJu commented Dec 30, 2023

/cherry-pick version-2023.10

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1c3cce1) 92.44% compared to head (a396089) 92.29%.
Report is 2 commits behind head on main.

Files Patch % Lines
...hentik/outposts/controllers/k8s/service_monitor.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8021      +/-   ##
==========================================
- Coverage   92.44%   92.29%   -0.16%     
==========================================
  Files         594      594              
  Lines       29551    29560       +9     
==========================================
- Hits        27318    27281      -37     
- Misses       2233     2279      +46     
Flag Coverage Δ
e2e 49.45% <36.36%> (-1.22%) ⬇️
integration 26.17% <81.81%> (+0.01%) ⬆️
unit 89.56% <45.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…st in code instead of in config

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the outposts/disable-reconciler-in-code branch from fec9f30 to a396089 Compare December 30, 2023 17:39
Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit a396089
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/659055dcc39dd7000809dbf8
😎 Deploy Preview https://deploy-preview-8021--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu merged commit a365ec8 into main Dec 30, 2023
61 of 63 checks passed
@BeryJu BeryJu deleted the outposts/disable-reconciler-in-code branch December 30, 2023 20:32
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Dec 30, 2023
…st in code instead of in config (#8021)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Dec 30, 2023
…st in code instead of in config (cherry-pick #8021) (#8024)

outposts: disable deployment and secret reconciler for embedded outpost in code instead of in config (#8021)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Jan 2, 2024
* main: (30 commits)
  outposts/proxy: better Redis error message (#8044)
  translate: Updates for file web/xliff/en.xlf in fr (#8046)
  web: bump the eslint group in /tests/wdio with 2 updates (#8041)
  web: bump the storybook group in /web with 7 updates (#8042)
  web: bump the eslint group in /web with 2 updates (#8043)
  web: bump @types/guacamole-common-js from 1.3.2 to 1.5.2 in /web (#8030)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#8038)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#8039)
  website: bump clsx from 2.0.0 to 2.1.0 in /website (#8033)
  core: bump golang from 1.21.3-bookworm to 1.21.5-bookworm (#8027)
  web: bump the babel group in /web with 4 updates (#8028)
  web: bump the esbuild group in /web with 2 updates (#8029)
  web: bump rollup from 4.9.1 to 4.9.2 in /web (#8031)
  tests/e2e: fix tests to work without docker network_mode host (#8035)
  website/docs: fix typo (#8015)
  web: bump API Client version (#8025)
  enterprise/providers: Add RAC [AUTH-15] (#7291)
  outposts: disable deployment and secret reconciler for embedded outpost in code instead of in config (#8021)
  providers/proxy: use access token (#8022)
  website/integrations: Add custom Group/Role mapping documentation for Grafana (#7453)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant