Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/oauth2: fix offline_access requests when prompt doesn't include consent #8731

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 28, 2024

Details

closes #8660


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…lude consent

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner February 28, 2024 14:12
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 4ab42a0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65df3f69b7d3120009572599

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 4ab42a0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/65df3f68d464160008bb5d1d

@BeryJu
Copy link
Member Author

BeryJu commented Feb 28, 2024

/cherry-pick version-2024.2

@BeryJu BeryJu merged commit 99c03d3 into main Feb 28, 2024
60 checks passed
@BeryJu BeryJu deleted the providers/oauth2/fix-offline_access-without-prompt branch February 28, 2024 14:27
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Feb 28, 2024
…lude consent (#8731)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-4ab42a061d819d6b4839fb74c7ba726f5eb49680
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-4ab42a061d819d6b4839fb74c7ba726f5eb49680-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-4ab42a061d819d6b4839fb74c7ba726f5eb49680

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-4ab42a061d819d6b4839fb74c7ba726f5eb49680-arm64

Afterwards, run the upgrade commands from the latest release notes.

rissson pushed a commit that referenced this pull request Feb 28, 2024
…lude consent (cherry-pick #8731) (#8732)

Co-authored-by: Jens L <jens@goauthentik.io>
fix offline_access requests when prompt doesn't include consent (#8731)
kensternberg-authentik added a commit that referenced this pull request Feb 28, 2024
* main: (26 commits)
  stages/authenticator_webauthn: fix error when enrolling new device (#8738)
  website/docs: s3: fix migration docs (#8735)
  providers/oauth2: fix offline_access requests when prompt doesn't include consent (#8731)
  ci: fix missing DOCKER_USERNAME secret (#8730)
  website: post-split cleanup (#8729)
  website: bump @types/react from 18.2.58 to 18.2.60 in /website (#8714)
  core: bump pydantic from 2.6.1 to 2.6.3 (#8715)
  core: bump sentry-sdk from 1.40.5 to 1.40.6 (#8716)
  web: bump the sentry group in /web with 1 update (#8717)
  web: bump style-mod from 4.1.0 to 4.1.1 in /web (#8718)
  core: bump github.com/go-openapi/strfmt from 0.22.0 to 0.22.1 (#8719)
  core: bump github.com/prometheus/client_golang from 1.18.0 to 1.19.0 (#8720)
  root: fix container build (#8727)
  website/docs: s3: fix environment variables (#8722)
  enterprise: force license usage update after change to license (#8723)
  ci: do not push docker image if fork (#8724)
  translate: Updates for file web/xliff/en.xlf in fr (#8710)
  website/integrations: add documentation for OIDC setup with Paperless-ngx (#8538)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#8705)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#8706)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Authorization Server requires End-User consent when set the offline_access scope
1 participant