Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: update notes on SECRET_KEY #9091

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

pidi3000
Copy link
Contributor

@pidi3000 pidi3000 commented Apr 1, 2024

Details

The docs say the SECRET_KEY is used for 'unique user IDs' and to not change it.

This is no longer the case since 2023.06.0 and changing the SECRET_KEY only invalidates active sessions.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: pidi3000 <76975863+pidi3000@users.noreply.github.com>
@pidi3000 pidi3000 requested a review from a team as a code owner April 1, 2024 15:24
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 003701c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/660b3f40fbf5a10008621715

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 003701c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/660b3f40f46b6b0008a04cc0
😎 Deploy Preview https://deploy-preview-9091--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: pidi3000 <76975863+pidi3000@users.noreply.github.com>
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (cef1d2d) to head (003701c).
Report is 456 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9091       +/-   ##
===========================================
+ Coverage   46.62%   92.30%   +45.67%     
===========================================
  Files         626      641       +15     
  Lines       30996    31616      +620     
===========================================
+ Hits        14451    29182    +14731     
+ Misses      16545     2434    -14111     
Flag Coverage Δ
e2e 50.53% <ø> (+5.81%) ⬆️
integration 26.20% <ø> (+0.21%) ⬆️
unit 89.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit a899495 into goauthentik:main Apr 2, 2024
58 of 65 checks passed
kensternberg-authentik added a commit that referenced this pull request Apr 4, 2024
* main:
  root: fix missing imports after #9081 (#9106)
  root: move database calls from ready() to dedicated startup signal (#9081)
  web: fix console log leftover (#9096)
  web: bump the eslint group in /web with 2 updates (#9098)
  core: bump twilio from 9.0.2 to 9.0.3 (#9103)
  web: bump the eslint group in /tests/wdio with 2 updates (#9099)
  core: bump drf-spectacular from 0.27.1 to 0.27.2 (#9100)
  core: bump django-model-utils from 4.4.0 to 4.5.0 (#9101)
  core: bump ruff from 0.3.4 to 0.3.5 (#9102)
  website/docs:  update notes on SECRET_KEY (#9091)
  web: fix broken locale compile (#9095)
  website/integrations: add outline knowledge base (#8786)
  website/docs: fix typo (#9082)
  website/docs: email stage: fix example translation error (#9048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants