-
-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: fix locale loading being skipped #9301
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, and thanks, @Gunsmithy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9301 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 665 665
Lines 32609 32609
==========================================
- Hits 30126 30125 -1
- Misses 2483 2484 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* main: (23 commits) web: bump API Client version (#9316) release: 2024.2.3 website/docs: 2024.2.3 release notes (#9313) web/admin: fix log viewer empty state (#9315) website/docs: fix formatting for stage changes (#9314) core: bump github.com/go-ldap/ldap/v3 from 3.4.7 to 3.4.8 (#9310) core: bump goauthentik.io/api/v3 from 3.2024022.11 to 3.2024022.12 (#9311) web: bump core-js from 3.36.1 to 3.37.0 in /web (#9309) core: bump gunicorn from 21.2.0 to 22.0.0 (#9308) core, web: update translations (#9307) website/docs: system settings: add default token duration and length (#9306) web/flows: update flow background (#9305) web: fix locale loading being skipped (#9301) translate: Updates for file web/xliff/en.xlf in fr (#9304) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#9303) core: replace authentik_signals_ignored_fields with audit_ignore (#9291) web/flow: fix form input rendering issue (#9297) events: fix incorrect user logged when using API token authentication (#9302) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9293) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9295) ...
Details
Hey there,
I noticed on authentik that no matter what browser locale I had set or what locale I passed to the query string, the locale would always be loaded as 'en'.
After looking at the code, I attributed a potential fix to the one line I reference in this PR. I did a Chrome local override and this fixed the issue with the query string being ignored, but it still doesn't seem to consider the browser headers.
The lack of consideration for browser headers may be due to an issue with
autoDetectLanguage
where it never defaultsrequestedCode
toTOMBSTONE
becauserequestedCode
is always set toen
fromDEFAULT_LOCALE
so it's not really an optional.I'm at work so I didn't have sufficient time to determine if this is an acceptable fix for at least the query string issue, nor run any local tests, so this PR is more meant to serve as an Issue for review/discussion.
I'll see if I can explore it more in the future if I can find some time to set up a proper local dev environment.
Let me know if I can provide any more additional info.
Thanks,
Dylan
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)