-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stages/authenticator_webauthn: fix attestation value #9333
stages/authenticator_webauthn: fix attestation value #9333
Conversation
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9333 +/- ##
==========================================
- Coverage 92.39% 92.39% -0.01%
==========================================
Files 667 667
Lines 32630 32629 -1
==========================================
- Hits 30150 30147 -3
- Misses 2480 2482 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-4d63fa26dc2938ecf2c635faf605a3dd1e8d32ff
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s For arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-4d63fa26dc2938ecf2c635faf605a3dd1e8d32ff-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s Afterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ghcr.io/goauthentik/dev-server:gh-4d63fa26dc2938ecf2c635faf605a3dd1e8d32ff For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ghcr.io/goauthentik/dev-server:gh-4d63fa26dc2938ecf2c635faf605a3dd1e8d32ff-arm64 Afterwards, run the upgrade commands from the latest release notes. |
…rities' into web/bug/locale-priorities * refs/remotes/origin/web/bug/locale-priorities: web: fix locale prioritization scheme core: bump aiohttp from 3.9.2 to 3.9.4 (#9339) stages/prompt: fix username field throwing error with existing user (#9342) root: expose session storage configuration (#9337) website/integrations: fix typo (#9340) root: fix go.mod for codeql checking (#9338) root: make redis settings more consistent (#9335) web/admin: fix error in admin interface due to un-hydrated context (#9336) web: bump API Client version (#9334) stages/authenticator_webauthn: fix attestation value (#9333) website/docs: fix SECRET_KEY length (#9328) website/docs: fix email template formatting (#9330) core, web: update translations (#9323) web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324) core: bump celery from 5.3.6 to 5.4.0 (#9325) core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327) sources/scim: service account should be internal (#9321) web: bump the storybook group in /web with 8 updates (#9266) sources/scim: cleanup service account when source is deleted (#9319)
* main: stages/prompt: fix username field throwing error with existing user (#9342) root: expose session storage configuration (#9337) website/integrations: fix typo (#9340) root: fix go.mod for codeql checking (#9338) root: make redis settings more consistent (#9335) web/admin: fix error in admin interface due to un-hydrated context (#9336) web: bump API Client version (#9334) stages/authenticator_webauthn: fix attestation value (#9333) website/docs: fix SECRET_KEY length (#9328) website/docs: fix email template formatting (#9330) core, web: update translations (#9323) web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324) core: bump celery from 5.3.6 to 5.4.0 (#9325) core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327) sources/scim: service account should be internal (#9321) web: bump the storybook group in /web with 8 updates (#9266) sources/scim: cleanup service account when source is deleted (#9319)
Details
This fixes issues where authenticators don't return their aaguid due to attestation conveyance being set to
enterprise
In addition this also saves the raw AAGUID of the authenticator even when there is no compatible device type in our library
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)