Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Add resolved and integrity fields back to package-lock.json #9419

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

jvanbruegge
Copy link
Contributor

fixes #6180

This also adds a new job in CI that checks that the lockfile is fully resolved, so this does not happen again in the future

I fixed the lockfile with

cd website
nix run github:jeslie0/npm-lockfile-fix ./package-lock.json
npm install

@jvanbruegge jvanbruegge requested review from a team as code owners April 25, 2024 09:12
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 58314af
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/662a1e6f6c22f200083a4244

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 58314af
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/662a1e6fa28618000848ab3a
😎 Deploy Preview https://deploy-preview-9419--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu
Copy link
Member

BeryJu commented Apr 25, 2024

Thanks for the PR and also providing a way to prevent this from happening in the future!

I'm not sure if this can easily be cherry-picked to 2024.4, but will try once this is merged

@BeryJu
Copy link
Member

BeryJu commented Apr 25, 2024

/cherry-pick version-2024.4

@BeryJu BeryJu changed the title Add resolved and integrity fields back to package-lock.json web: Add resolved and integrity fields back to package-lock.json Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (80af26e) to head (58314af).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9419      +/-   ##
==========================================
- Coverage   92.42%   92.41%   -0.01%     
==========================================
  Files         668      668              
  Lines       32669    32669              
==========================================
- Hits        30194    30192       -2     
- Misses       2475     2477       +2     
Flag Coverage Δ
e2e 50.67% <ø> (-0.01%) ⬇️
integration 26.02% <ø> (ø)
unit 89.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 64f7fa6 into goauthentik:main Apr 25, 2024
48 of 54 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 25, 2024
* web: Fix missing resolved and integrity fields in package-lock.json

* web,website: Add lockfile lint to CI
@jvanbruegge jvanbruegge deleted the fix-lockfile branch April 25, 2024 10:30
BeryJu pushed a commit that referenced this pull request Apr 25, 2024
…rry-pick #9419) (#9421)

web: Add resolved and integrity fields back to package-lock.json (#9419)

* web: Fix missing resolved and integrity fields in package-lock.json

* web,website: Add lockfile lint to CI

Co-authored-by: Jan van Brügge <supermanitu@gmail.com>
kensternberg-authentik added a commit that referenced this pull request Apr 30, 2024
* main:
  web: clean up some repetitive types (#9241)
  core: fix logic for token expiration (#9426)
  ci: fix ci pipeline (#9427)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9424)
  web: Add resolved and integrity fields back to package-lock.json (#9419)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9407)
  stages/identification: don't check source component (#9410)
  core: bump selenium from 4.19.0 to 4.20.0 (#9411)
  core: bump black from 24.4.0 to 24.4.1 (#9412)
  ci: bump golangci/golangci-lint-action from 4 to 5 (#9413)
  core: bump goauthentik.io/api/v3 from 3.2024023.2 to 3.2024040.1 (#9414)
  web: bump @sentry/browser from 7.112.1 to 7.112.2 in /web in the sentry group (#9416)
  sources/oauth: ensure all UI sources return a valid source (#9401)
  web: markdown: display markdown even when frontmatter is missing (#9404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please provide package-lock.json with fully resolved dependencies again
2 participants