Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/common: fix locale detection for user-set locale #9436

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 25, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner April 25, 2024 17:55
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit f9b19bf
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/662a99216b1f640008c30f4a

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit f9b19bf
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/662a99211bcdde00087d3cf6
😎 Deploy Preview https://deploy-preview-9436--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu
Copy link
Member Author

BeryJu commented Apr 25, 2024

/cherry-pick version-2024.4

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (c801164) to head (f9b19bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9436   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         668      668           
  Lines       32666    32666           
=======================================
  Hits        30190    30190           
  Misses       2476     2476           
Flag Coverage Δ
e2e 50.67% <ø> (+0.01%) ⬆️
integration 26.02% <ø> (ø)
unit 89.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-f9b19bffac26d445ee1a6ba17ccd4f370e251947
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-f9b19bffac26d445ee1a6ba17ccd4f370e251947-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-f9b19bffac26d445ee1a6ba17ccd4f370e251947

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-f9b19bffac26d445ee1a6ba17ccd4f370e251947-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 8d37e83 into main Apr 25, 2024
69 checks passed
@BeryJu BeryJu deleted the web/common/fix-user-locale branch April 25, 2024 20:36
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 25, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Apr 25, 2024
…) (#9439)

web/common: fix locale detection for user-set locale (#9436)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants