Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: fix geoip enrich context not converting to json-seriazable data #9885

Merged
merged 1 commit into from
May 27, 2024

Conversation

rissson
Copy link
Member

@rissson rissson commented May 27, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this May 27, 2024
@rissson rissson requested a review from a team as a code owner May 27, 2024 16:36
Copy link

netlify bot commented May 27, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 60374c4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6654bace6692b000074b2ecf

Copy link

netlify bot commented May 27, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 60374c4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6654baceb393e10008e643a0

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.63%. Comparing base (2cff3d1) to head (c16a694).

Current head c16a694 differs from pull request most recent head 60374c4

Please upload reports for the commit 60374c4 to get more accurate results.

Files Patch % Lines
authentik/events/context_processors/geoip.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9885   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files         710      710           
  Lines       34745    34745           
=======================================
+ Hits        32186    32187    +1     
+ Misses       2559     2558    -1     
Flag Coverage Δ
e2e 49.65% <0.00%> (ø)
integration 25.50% <0.00%> (ø)
unit 90.09% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson force-pushed the fix-geoip-enrich-context branch 2 times, most recently from c16a694 to 60374c4 Compare May 27, 2024 16:54
@rissson rissson enabled auto-merge (squash) May 27, 2024 17:02
Copy link
Contributor

github-actions bot commented May 27, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-60374c4145c7e1f1ba2df7606d4f0d14cc49c84a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-60374c4145c7e1f1ba2df7606d4f0d14cc49c84a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-60374c4145c7e1f1ba2df7606d4f0d14cc49c84a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-60374c4145c7e1f1ba2df7606d4f0d14cc49c84a-arm64

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson merged commit 0e4737d into main May 27, 2024
69 of 70 checks passed
@rissson rissson deleted the fix-geoip-enrich-context branch May 27, 2024 17:16
kensternberg-authentik added a commit that referenced this pull request Jun 11, 2024
* main:
  website/docs: add docs for configuring Facebook as a source (#9884)
  web: bump the esbuild group in /web with 2 updates (#9879)
  core: bump twilio from 9.0.5 to 9.1.0 (#9875)
  core: bump coverage from 7.5.1 to 7.5.2 (#9876)
  core: bump goauthentik.io/api/v3 from 3.2024042.7 to 3.2024042.8 (#9877)
  web: bump the babel group in /web with 7 updates (#9878)
  web: bump glob from 10.4.0 to 10.4.1 in /web (#9881)
  web: bump the wdio group in /tests/wdio with 4 updates (#9882)
  events: fix geoip enrich context not converting to json-seriazable data (#9885)
  stages/user_login: fix non-json-serializable being used (#9886)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants