Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(DashboardTableBlocks): remove sortable attribute from rewards #1119

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

LuccaBitfly
Copy link
Contributor

@LuccaBitfly LuccaBitfly commented Nov 12, 2024

Removes sort from proposer rewards in validator dashboard blocks table.

Before PR:
image

After PR:
image

Copy link

cloudflare-workers-and-pages bot commented Nov 12, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3bfb42d
Status: ✅  Deploy successful!
Preview URL: https://a0adff1b.beaconchain.pages.dev
Branch Preview URL: https://beds-947-disable-vdb-blocks.beaconchain.pages.dev

View logs

@benji-bitfly
Copy link
Contributor

Np: the commit message: for better changelog readability

refactor(DashboardTableBlocks): remove sortable attribute

See: BEDS-947

Copy link
Contributor

@benji-bitfly benji-bitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks @LuccaBitfly 👋

@LuccaBitfly LuccaBitfly force-pushed the BEDS-947/disable-vdb-blocks-reward-sort branch from 03128b4 to 3bfb42d Compare November 12, 2024 13:07
@LuccaBitfly LuccaBitfly merged commit fed5140 into staging Nov 12, 2024
2 checks passed
@LuccaBitfly LuccaBitfly deleted the BEDS-947/disable-vdb-blocks-reward-sort branch November 12, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants