Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beds 202/notification table RocketPool tab #879

Merged
merged 9 commits into from
Sep 25, 2024

Conversation

benji-bitfly
Copy link
Contributor

  • add new Component NotificationsRocketPoolTable.vue to display Rocket Pool Data,
  • add store useNotificationsRocketPoolStore.ts for Rocket Pool data,
  • add translations for the new component,
  • change background-color for the manage-modal ( 50% black )
  • refactore data-key in NotificationsClientsTable.vue
  • add the correct title translation for NotificationsNetworkTable.vue
  • update endpoints in customFetch.ts for the Rocket Pool

See: BEDS-202

@marcel-bitfly marcel-bitfly force-pushed the BEDS-202/Notification-Table-RP-Tab branch from 2fa9677 to 4221327 Compare September 24, 2024 07:38
Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2024

Deploying beaconchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 155f484
Status: ✅  Deploy successful!
Preview URL: https://2c7efed1.beaconchain.pages.dev
Branch Preview URL: https://beds-202-notification-table.beaconchain.pages.dev

View logs

@marcel-bitfly marcel-bitfly force-pushed the BEDS-202/Notification-Table-RP-Tab branch 3 times, most recently from 7b9d461 to a0f3476 Compare September 25, 2024 06:15
It is easier to work with components if their name reflect
the file path in nuxt.
This can be used to see what the `feature-flag`s are active depending
on the `specific environment`.
Data-key is used for the `primevue component` to identify
the `row objects`an used for performatce optimizations.

`Data-key` must be a prop of the object.
Text with optional `left-info` and `right-info` now positions correctly
depending on the breakpoint.
@marcel-bitfly marcel-bitfly force-pushed the BEDS-202/Notification-Table-RP-Tab branch from a0f3476 to d0bc3b3 Compare September 25, 2024 09:32
See: BEDS-202

Co-authored-by: benji-bitfly <beniamin.hutyra@bitfly.at>
@marcel-bitfly marcel-bitfly force-pushed the BEDS-202/Notification-Table-RP-Tab branch from d0bc3b3 to 155f484 Compare September 25, 2024 10:28
@benji-bitfly benji-bitfly merged commit 7d35b43 into staging Sep 25, 2024
2 checks passed
@benji-bitfly benji-bitfly deleted the BEDS-202/Notification-Table-RP-Tab branch September 25, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants