Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bids 2481/all datatables should be debounced #2567

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

Eisei24
Copy link
Collaborator

@Eisei24 Eisei24 commented Sep 20, 2023

🤖 Generated by Copilot at a29b4ae

The pull request refactors the code for loading data from the server for various DataTables in the web pages. It introduces a common function dataTableLoader in datatable_loader.js that handles the server requests with retries and extra query parameters. It replaces the ajax option for many DataTables with a call to this function, and imports the datatable_loader.js file in the templates that use it. This improves the reliability and performance of the data loading and rendering.

templates/validator/tables.html Show resolved Hide resolved
templates/validators.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eisei24 Eisei24 merged commit 12b7a56 into master Oct 18, 2023
3 checks passed
@Eisei24 Eisei24 deleted the BIDS-2481/All_datatables_should_be_debounced branch October 18, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants