Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multi-threaded valid-memcleanup #1246

Merged
merged 23 commits into from
Nov 24, 2023
Merged

Improve multi-threaded valid-memcleanup #1246

merged 23 commits into from
Nov 24, 2023

Commits on Nov 16, 2023

  1. First attempt to improve precision for multi-threaded valid-memcleanup

    @mrstanb
    mrstanb committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f209afd View commit details
    Browse the repository at this point in the history

  2. Add regr. test cases for multi-threaded valid-memcleanup

    @mrstanb
    mrstanb committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c0fe89e View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Use solely local state for multi-threaded valid-memcleanup

    @mrstanb
    mrstanb committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    7289ec3 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. IsMallocCalled should be may

    @michael-schwarz
    michael-schwarz committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    720cfee View commit details
    Browse the repository at this point in the history

  2. Add unsound example

    @michael-schwarz
    michael-schwarz committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    af9ddc7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into improve-multi-threaded-valid-memcleanup

    @michael-schwarz
    michael-schwarz committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    0655fd6 View commit details
    Browse the repository at this point in the history

  4. Make sound by accounting for alloc in global invariant

    @michael-schwarz
    michael-schwarz committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    ada8491 View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @michael-schwarz
    michael-schwarz committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    e7d6302 View commit details
    Browse the repository at this point in the history

  6. Fix memtrack for multi-threaded case

    @michael-schwarz
    michael-schwarz committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    e6cee27 View commit details
    Browse the repository at this point in the history

  7. Account for failing assertions in the multi-threaded case as well

    @mrstanb
    mrstanb committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    97eb715 View commit details
    Browse the repository at this point in the history

  8. Add a few more test cases

    @mrstanb
    mrstanb committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    987795e View commit details
    Browse the repository at this point in the history

  9. Add options to produce warnings only for memory leaks 

    due to `memcleanup` or `memtrack` violations
    @mrstanb
    mrstanb committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    8d55024 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Add example where better privatization helps

    @michael-schwarz
    michael-schwarz committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ca61360 View commit details
    Browse the repository at this point in the history

  2. Check at end of main thread that the program is certainly single-thre… 

    …aded.

If other threads are not joined, they may be killed by the main thread returning.
This will possibly leak memory.
    @jerhard
    jerhard committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2cc915f View commit details
    Browse the repository at this point in the history

  3. Add test case for memory leaking from a thead that is not joined, add… 

    … thread_joins to other test cases.
    @jerhard
    jerhard committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    45ec8a6 View commit details
    Browse the repository at this point in the history

  4. Add test case with pthread_exit called in main, remove threadid analy… 

    …sis from params as it is not needed.
    @jerhard
    jerhard committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    56c4d62 View commit details
    Browse the repository at this point in the history

  5. Add testcases for thread return and pthread_exit in thread different … 

    …from main.
    @jerhard
    jerhard committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2fef812 View commit details
    Browse the repository at this point in the history

  6. ThreadAnalysis: Handle pthread_exit like return from thread.

    @jerhard
    jerhard committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    645b03c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Update tests/regression/76-memleak/16-no-mem-leak-thread-exit-main.c 

    Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
    @jerhard @sim642
    jerhard and sim642 authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c6cb63e View commit details
    Browse the repository at this point in the history

  2. Remove call to free.

    @jerhard
    jerhard committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f12a392 View commit details
    Browse the repository at this point in the history

  3. Add annotation of nowarn next to pthread_exit.

    @jerhard
    jerhard committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    be9171b View commit details
    Browse the repository at this point in the history

  4. Check in TheadAnalysis.return whether the return is actually a thread… 

    …return before side-effecting.
    @jerhard
    jerhard committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    585a65d View commit details
    Browse the repository at this point in the history

  5. Add test case that checking that analysis distinguishes between threa… 

    …d returns and normal returns of a thread.
    @jerhard
    jerhard committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    bc7694b View commit details
    Browse the repository at this point in the history