Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce option warn with options post | early | never #219

Merged
merged 5 commits into from
May 10, 2021

Conversation

michael-schwarz
Copy link
Member

The behavior is as follows:

  • default: Warn in verifying phase, run verification regardless of verify, do not report problems if verify is false
  • early: Same as above except that during solving warnings are already produced
  • none: Do not produce warnings. Verification is run iff verify is true

Also the unused option ana.warnings was removed, and the config for incremental was fixed.

warn set to early replaces dbg.earlywarn.

Closes #88. References #28

@sim642
Copy link
Member

sim642 commented May 7, 2021

I didn't look at anything else yet, but the value default seems weird, because then you have the option's default value be default, which isn't descriptive at all. But I don't know what the ideal alternative would be either. Maybe solved as in it's reporting them on the solved state, or post as in post-solving?

Maybe we need a new name for the verification phase, if it can be used either for verifying the solution or for reporting warnings.

@michael-schwarz
Copy link
Member Author

post as in post-solving?

I renamed it thus.

Maybe we need a new name for the verification phase, if it can be used either for verifying the solution or for reporting warnings.

I would want to stick with verify as that also makes sense in purely the fixpoint sense, especially since verify is likely not set to false too often, so it is very seldom that is used not only for verifying and only for warning.

@michael-schwarz michael-schwarz changed the title Introduce option warn with options default | early | never Introduce option warn with options post | early | never May 10, 2021
@michael-schwarz michael-schwarz merged commit ae0e7e1 into master May 10, 2021
@michael-schwarz michael-schwarz deleted the no_verify_allow_warnings branch May 10, 2021 08:21
@sim642 sim642 added cleanup Refactoring, clean-up usability labels May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

options for warnings/post-processing
2 participants