Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fixed various fixer issues #161

Merged
merged 3 commits into from
May 29, 2022
Merged

fixed various fixer issues #161

merged 3 commits into from
May 29, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented May 27, 2022

Fixed various fixer issues:

  • fixed yarn install error on berry enabled tree
  • fixed "Error: open main.go" error when fixing recent versions
    • made deprecations fix to use new structure
    • moved structural fixes to the beginning of the fix sequence
  • moved Refresh() into the movemain.go file (related fixes)
  • added related test case (TestFix_Self: run fix against a new app)
  • misc fixes: removing space, get y/n answer in the same line
  • version bump (to 0.18.6)

error message for the location of main.go (deprecations):

~~~ Checking for deprecations ~~~
<...>
time="2022-05-27T20:06:03+09:00" level=error msg="Error: open main.go: no such file or directory"

error message for the yarn install issue:

~~~ Checking package.json ~~~
Unknown Syntax Error: Unsupported option name ("--no-progress").

@sio4 sio4 added the bug Something isn't working label May 27, 2022
@sio4 sio4 requested review from paganotoni and a team May 27, 2022 11:26
@sio4 sio4 self-assigned this May 27, 2022
@sio4 sio4 enabled auto-merge (rebase) May 27, 2022 13:50
@sio4 sio4 marked this pull request as draft May 27, 2022 13:51
auto-merge was automatically disabled May 27, 2022 13:51

Pull request was converted to draft

@sio4 sio4 marked this pull request as ready for review May 27, 2022 15:36
@sio4 sio4 enabled auto-merge (rebase) May 27, 2022 15:36
Copy link
Member

@paganotoni paganotoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks for the fixes. One note on Yarn. I've seen that even when my repo uses npm yarn gets invoked. Will open an issue with it.

@sio4 sio4 merged commit c3010de into development May 29, 2022
@paganotoni paganotoni deleted the fixing-misc-fixer-issues branch May 29, 2022 19:29
@sio4 sio4 mentioned this pull request Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants