fixed broken behavior of buffalo test -m #181
Conversation
| for _, freeCmd := range anywhereCommands { | ||
| if freeCmd != cmd.Name() { | ||
| if freeCmd == cmdName { |
There was a problem hiding this comment.
If the current command (subcommand) is one of anywhereCommands, just returns nil and stops prechecking. Otherwise, the command should be executed within the application directory that can be determined by checking .buffalo.dev.yml currently.
| cmdName := cmd.Name() | ||
| if cmd.Parent() != cmd.Root() { | ||
| // e.g. `completion` for `buffalo completion bash` instead of `bash` | ||
| cmdName = cmd.Parent().Name() |
There was a problem hiding this comment.
it is possible that some "current command" is not a direct child of root but a grandchild. they should be checked with the name of their parent.
| @@ -28,7 +28,8 @@ func plugs() plugins.List { | |||
| func decorate(name string, cmd *cobra.Command) { | |||
| pugs := plugs() | |||
| for _, c := range pugs[name] { | |||
| anywhereCommands = append(anywhereCommands, c.Name) | |||
There was a problem hiding this comment.
plugins are not anywhere commands. they should be executed within the app directory.
| @@ -94,20 +92,9 @@ func runDevScript(ctx context.Context, app meta.App) error { | |||
| func startDevServer(ctx context.Context, args []string) error { | |||
| app := meta.New(".") | |||
|
|
|||
| cfgFile := "./.buffalo.dev.yml" | |||
There was a problem hiding this comment.
dev command is not an anywhere command, so if the command was executed from the directory that has no .buffalo.dev.yml, the execution will be aborted by the root's pre-checking and this block should not be reachable.
| @@ -156,11 +156,12 @@ func (m mFlagRunner) Run() error { | |||
| continue | |||
| } | |||
|
|
|||
| cmd := newTestCmd(m.args) | |||
There was a problem hiding this comment.
a command should be built within the app's root so the correct configuration was applied.
| @@ -178,8 +179,9 @@ func (m mFlagRunner) Run() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func hasTestify(p string) bool { | |||
| cmd := exec.Command("go", "test", "-thisflagdoesntexist") | |||
| func hasTestify(args []string) bool { | |||
There was a problem hiding this comment.
the base of the checking command also should be a complete command (except the last wrong argument which causes an intentional error) so the execution can be guaranteed.
sio4
force-pushed
the
fixing-buffalo-test-m
branch
from
f7aad8b
to
d9a2fd2
Compare
|
This |
In our code, the
So what I found for |
|
Was taking the time to review how this impacted the v1 version of all this. Thanks for adding the comments @sio4. |
Not sure when the issue started, but
buffalo test -m TESTwas not working as expected. The bug was reported as #180 recently (transferred from thebuffalorepository).This fix fixes the following things:
.buffalo.dev.ymlexistence checking onbuffalo devcommand. The logic should not reach there since therootCmdchecks that before executing subcommands.anywhereCommandschecking.anywhereCommandsmeans they can be executed outside app root.anywhereCommands. (maybe related to the above miss-checking?)buffalo test -mhandles argument properly especially withtestify.fixes #180