This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
applied sync.Once to make 'app' to be the only root App #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2022
Closed
sio4
added a commit
that referenced
this pull request
Oct 8, 2022
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a fix for the v1)
Applied
sync.Oncefor app initialization (template for scaffold) to fix #228 and gobuffalo/buffalo#1653. (actually the same issue, but keep them all in each project since this issue could be imaged as the core library's issue) It also related to the review discussion on gobuffalo/buffalo#2239.For the long term, this issue could be resolved by gobuffalo/buffalo#2240
The first commit fixes the
App()to usesync.Oncefor the initialization function. To make the CLI compatible with the old version of apps which was created with old versions, the second commit treats those errors and fallback to the old method.It could be better to have a fixer for this, and I am considering that.
fixes #228
fixes gobuffalo/buffalo#1653