Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

bugfix: fixing goreleaser binary match #248

Merged
merged 1 commit into from
Dec 7, 2022
Merged

bugfix: fixing goreleaser binary match #248

merged 1 commit into from
Dec 7, 2022

Conversation

paganotoni
Copy link
Member

What is being done in this PR?

This PR specifies the architecture of the binary being used when building both images.

What are the main choices made to get to this solution?

Specifying the goos and goarch in the goreleaser file.

What was discovered while working on it? (Optional)

Did not know about those 2 variables to be set.

List the manual test cases you've covered before sending this PR:

E.g: I ran installed and ran the CLI locally and ran the following commands ...

@paganotoni paganotoni requested a review from a team as a code owner December 7, 2022 01:07
@paganotoni paganotoni merged commit 3648c1a into main Dec 7, 2022
@paganotoni paganotoni deleted the task-fixing-docker-binaries branch December 7, 2022 12:26
@paganotoni
Copy link
Member Author

Related to #249

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paganotoni